Closed Bug 309372 Opened 19 years ago Closed 18 years ago

Add WebWatch Feed to mozilla.org homepage

Categories

(www.mozilla.org :: General, defect)

x86
Windows XP
defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: rebron, Assigned: reed)

Details

Attachments

(3 obsolete files)

Display WebWatch Feed
http://developer.mozilla.org/webwatch/?feed=rss2

Similar to how we have Announcements and mozillaZine news.  Web Watch feed will
take the place of the "other mozilla software" column.
--> www.mozilla.org
Assignee: myk → nobody
Component: Miscellaneous → www.mozilla.org
QA Contact: mitchell → www-mozilla-org
Is this still wanted as a replacement for "Other Mozilla Software"?
Yes, but the links to Other Mozilla Software should go to Mozilla Projects on the left.
hmm, feed2html.tmpl cannot handle wordpress' feed?
/webwatch/?feed=rss2 and /webwatch/?feed=rss cause no list.
/webwatch/?feed=atom causes HASH as title, shown below.
i tested on win32 and debian, and get same result.

the title are this form:
<title type="text/html" mode="escaped"><![CDATA[ blah blah blah ]]></title>

    <h2 style="margin-top: 0;">
      <a href="http://developer.mozilla.org/webwatch">WebWatch News</a>
    </h2>

    <ul class="news">
        <li>
          <div class="date">Feb 17</div>
          <a href="http://developer.mozilla.org/webwatch/?p=164" title="HASH(0x28a5380)">HASH(0x28a5380)</a>
        </li>
        <li>
          <div class="date">Feb 17</div>
          <a href="http://developer.mozilla.org/webwatch/?p=163" title="HASH(0x28a595c)">HASH(0x28a595c)</a>
        </li>
        <li>
          <div class="date">Feb 15</div>
          <a href="http://developer.mozilla.org/webwatch/?p=161" title="HASH(0x288c3d4)">HASH(0x288c3d4)</a>
        </li>    </ul>  </div>
Attached patch patch v1 (obsolete) β€” β€” Splinter Review
index: replace Mozilla Projects by Other Mozilla Software
feed2html: add conditions for wordpress' feed,
  add variable for multiple rows(this is only for div class, not mandatory though)
Attachment #216948 - Flags: review?
Comment on attachment 216948 [details] [diff] [review]
patch v1

>   <div class="frontcolumn">
>-    <h2><a href="projects/">Mozilla Projects</a></h2>
>-    Mozilla.org is the place to learn about contributing to open source Mozilla projects. <a href="projects/">Find out more...</a>
>-  </div>

^^ Why did you get rid of this? That is supposed to stay. The "Other Mozilla Projects" is what is supposed to be replaced with the WebWatch feed.

>       <a href="products/">Other Mozilla Software</a>

^^ That's the section that's supposed to be removed.

Please fix this and resubmit. :)
Attachment #216948 - Flags: review? → review-
(In reply to comment #6)
> ^^ Why did you get rid of this? That is supposed to stay. The "Other Mozilla

i thought they says so.
if not, feel free fix it.

> Please fix this and resubmit. :)

NO. to fix according to nit review without code review is just useless.
i never do it. i suggest you to do it yourself.
Assignee: nobody → reed
(In reply to comment #7)
> > Please fix this and resubmit. :)
> 
> NO. to fix according to nit review without code review is just useless.
> i never do it. i suggest you to do it yourself.

"nit review"? You completely missed the point of what was wanted. I'd say that classifies as more than just a "nit" about something. ;)
Assignee: reed → bmo
Assignee: bmo → reed
Assignee: reed → bmo
i never update it
Assignee: bmo → reed
Reassigning to nobody@mozilla.org.

victory(_RSZ_), FYI, It's not proper to assign a bug to someone who does not want it (as evidenced by Reed reassigning it to you.  If you don't want it anymore, just reassign it to nobody@mozilla.org
Assignee: reed → nobody
Attached patch remove actual content from previous patch (obsolete) β€” β€” Splinter Review
as i don't mention its content,
 and reeed did only content review,
 then no one mentioned oher part
 and unfortunately be standing for 8 months :-(
Attachment #216948 - Attachment is obsolete: true
Attachment #222325 - Flags: review?
Taking. I now have a local build of the website on landfill to use.

I've applied victory's patch and removed the "Other Mozilla Software" section.
You can see it at http://landfill.bugzilla.org/reed/mozilla.org/.

The patch now requires both somebody in the frontpages and tools partitions to commit it (as it has changes for html/index.html and tools/*). I'll attach a new patch in a bit.
Assignee: nobody → reed
This is the combined patch.
Attachment #222325 - Attachment is obsolete: true
Attachment #222325 - Flags: review?
Quote from IRC:
<@justdave> so we lose all the other mozilla software links?
* @justdave is disappointed at losing the link to bugzilla.org from there

What if we morphed "other mozilla software" into a narrow rectangle below the feeds? Would that work?
Status: NEW → ASSIGNED
See comment 3.
Comment on attachment 230301 [details] [diff] [review]
Combines victory's patch with index.html change

Oops, I didn't even see comment #3. :/

Ok, how's http://landfill.bugzilla.org/reed/mozilla.org/ looking? Ignore the seamonkey %% stuff for now. The main thing I'm torn about is if I should use the "folder" icon or not.
Attachment #230301 - Attachment is obsolete: true
looks good.  Probably don't need the folder icon.
I'd like it better if we's move the "Mozilla Foundation" section to the left of the middle block, and place the "Other Mozilla Software" section at the right instead of the "Mozilla Projects" one. That new section should look like after my patch to bug 341804, IMHO...
Checking in html/index.html;
/cvsroot/mozilla-org/html/index.html,v  <--  index.html
new revision: 1.581; previous revision: 1.580
done
Checking in tools/check.pl;
/cvsroot/mozilla-org/tools/check.pl,v  <--  check.pl
new revision: 1.3; previous revision: 1.2
done
Checking in tools/dostage;
/cvsroot/mozilla-org/tools/dostage,v  <--  dostage
new revision: 1.3; previous revision: 1.2
done
Checking in tools/feed2html.tmpl;
/cvsroot/mozilla-org/tools/feed2html.tmpl,v  <--  feed2html.tmpl
new revision: 1.11; previous revision: 1.10
done
Checking in tools/feeds.xml;
/cvsroot/mozilla-org/tools/feeds.xml,v  <--  feeds.xml
new revision: 1.8; previous revision: 1.7
done
Checking in tools/makemake.pl;
/cvsroot/mozilla-org/tools/makemake.pl,v  <--  makemake.pl
new revision: 1.11; previous revision: 1.10
done
Checking in tools/munge.pl;
/cvsroot/mozilla-org/tools/munge.pl,v  <--  munge.pl
new revision: 1.38; previous revision: 1.37
done
Checking in tools/wrap.pl;
/cvsroot/mozilla-org/tools/wrap.pl,v  <--  wrap.pl
new revision: 1.58; previous revision: 1.57
done
Status: ASSIGNED → RESOLVED
Closed: 18 years ago
Resolution: --- → FIXED
Product: mozilla.org → Websites
Component: www.mozilla.org → General
Product: Websites → www.mozilla.org
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: