309376 - Updated bookmarks.html without non-functional and aggressive live bookmarks

Status: RESOLVED FIXED

(Mozilla Localizations :: es-ES / Spanish, defect)

Description

[RickieES aka Ricardo Palomares]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.8b2) Gecko/20050706 SeaMonkey/1.0a Mnenhy/0.7.2.0
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; es-ES; rv:1.8b2) Gecko/20050706 SeaMonkey/1.0a Mnenhy/0.7.2.0

es-ES translation for Mozilla Firefox 1.0.x shipped a bookmarks.html which
included two live bookmarks, one pointing to
http://noticias.dirson.com/rss_0_91.xml for latest general news, and the other
one pointing to http://www.mozillaes.org/index2.php?option=com_rss&no_html=1, a
spanish language Mozilla community portal.

The first link seems to not be working anymore, whereas the second one caused,
due to a bunch of circunstances, a DDoS attack on the website. So, we request an
update to bookmarks.html removing both bookmarks and adding one to Mozilla
Europe's RDF feed, located at http://www.mozilla-europe.org/es/news.rdf.


Reproducible: Always

Steps to Reproduce:
1. Select Firefox es-ES live bookmark at personal toolbar folder (Dirson)
2. Try to get results
3. Sit and wait :-)

Comment 1

[RickieES aka Ricardo Palomares]

Attachment: Updated bookmarks.html removing conflicting live bookmarks

Comment 2

[RickieES aka Ricardo Palomares]

Attachment: Diff of the current bookmarks.html and the proposed in previous attachment

(hope this diff format is valid)

Comment 3

[RickieES aka Ricardo Palomares]

Attachment: Revised diff removing non-important changes due to irrelevant date updates

Previous diff included some changes due to bookmarks internal field to inform
of last visits, and some other irrelevant changes for this bug. All of them
have been removed.

Comment 4

[RickieES aka Ricardo Palomares]

Attachment: Diff with just the removal of MozillaES live bookmark

Comment 5

[Axel Hecht [:Pike]]

Comment on attachment 196831 [details]
Diff with just the removal of MozillaES live bookmark

Approving this for 1.0.x.

Please look out for a real news site (main stream TV or newspaper) and get
their approval to be included in 1.5. Mozilla-related news or mozilla community
news are not sufficiently interesting to the broad user base that we luckily
have.

Comment 6

[Andrés G. Aragoneses]

Fix checked in:

Checking in bookmarks.html;
/l10n/mozilla/browser/locales/es-ES/profile/Attic/bookmarks.html,v  <-- 
bookmarks.html
new revision: 1.1.2.3; previous revision: 1.1.2.2
done

Comment 7

[Oscar Manuel Gómez Senovilla]

Attachment: Patch for eliminating the live bookmark

The previous work has duplicated the live bookmark instead of deleting it. The
patch has been generated from browser/locales with cvs diff -u, so it must be
applied from this directory.

Comment 8

[Axel Hecht [:Pike]]

Reopening.
http://bonsai-l10n.mozilla.org/cvsview2.cgi?diff_mode=context&whitespace_mode=show&file=bookmarks.html&branch=AVIARY_1_0_20040515_BRANCH&root=/l10n&subdir=mozilla/browser/locales/es-ES/profile/Attic&command=DIFF_FRAMESET&rev1=1.1.2.2&rev2=1.1.2.3
is the check-in. Please take a deeper look at what you check in next time.

Please decide ASAP if you really want to sign off the 1.0.7 builds for Firefox,
see https://bugzilla.mozilla.org/show_bug.cgi?id=309375#c14.

Comment 9

[Axel Hecht [:Pike]]

Comment on attachment 196893 [details] [diff] [review]
Patch for eliminating the live bookmark

(this is still not a "-u" diff, but this time it's in the right direction)

Comment 10

[Axel Hecht [:Pike]]

(In reply to comment #8)
> Please decide ASAP if you really want to sign off the 1.0.7 builds for Firefox,
> see https://bugzilla.mozilla.org/show_bug.cgi?id=309375#c14.

Oops, sorry, that was for *eu* -ES, just a single letter off.

Comment 11

[Zibi Braniecki [:zbraniecki][:gandalf]]

Attachment: checked in patch

using a=pike from #l10n

Checking in browser/locales/es-ES/profile/bookmarks.html;
/l10n/mozilla/browser/locales/es-ES/profile/Attic/bookmarks.html,v  <-- 
bookmarks.html
new revision: 1.1.2.4; previous revision: 1.1.2.3
done

Comment 12

[Andrés G. Aragoneses]

Marking resolved again. Sorry for the last mistake.

I will mark verified when I am able to test the build.