309384 - Inconsistent showing of labels in help viewer

Status: RESOLVED WONTFIX

(SeaMonkey :: Help Viewer, defect)

Description

[Martijn Wargers (dead)]

The back button has a label, but the forward button not, for example.
Probably, all buttons need a label, not?

Comment 1

[Martijn Wargers (dead)]

Attachment: patch

This adds the labels to the forward button and the home button.

Comment 2

[Jeff Walden (gone starting June 8)]

Comment on attachment 196834 [details] [diff] [review]
patch

You want review from Mike here on this as it's a UI change.  I'm pretty sure
this was intentional, tho, so I'd bet this'll be marked WONTFIX.

Comment 3

[Ria Klaassen (not reading all bugmail)]

See Bug 307373.

Comment 4

[Mike Connor [:mconnor]]

Comment on attachment 196834 [details] [diff] [review]
patch

This was by design, and I intend to implement this for Firefox 2.0 as well

Comment 5

[Martijn Wargers (dead)]

Ok, then feel free to WONTFIX this bug.
But, I'm curious, what is the idea behind this?

Comment 6

[Mike Connor [:mconnor]]

selective text gives you bigger target areas for common actions, so the back
button is bigger than the forward button, which gets used a lot less.

Comment 7

[Steffen Wilberg]

*** Bug 312825 has been marked as a duplicate of this bug. ***

Comment 8

[Bamm Gabriana]

Here's what I wrote in the duplicate:

I appreciate that the Help window toolbar in the 1.5 branch has been given the
new "Selective text on right" look. However, although the -moz-box-orient:
horizontal has been added to the classic theme, the disappearance of the Forward
and Home button texts appears to have been hardcoded. This breaks themes that
have their -moz-box-orient set to vertical.

Instead, the text should be returned and the "Selective text on right" look
should be coded into the classic skin instead. This can be done by something like

#help-forward-button .toolbarbutton-text,
#help-home-button .toolbarbutton-text {
  display: none;
}

I am not against making the toolbar "Selective text". I just believe that there
are better ways to accomplish this without breaking other themes.

Comment 9

[Bamm Gabriana]

Attachment: Help window in IE Skin. Forward and Home button does not look good.

Note that -moz-box-orient: vertical is a must in IE Skin because it attempts to

copy the look of the help window in IE.

Comment 10

[Steffen Wilberg]

The labels weren't removed from help.dtd, so there's no l10n issue:
http://lxr.mozilla.org/mozilla1.8/source/toolkit/locales/en-US/chrome/mozapps/help/help.dtd

I'd suggest to make a patch (start with the first patch in this bug and add the
css to the help.css files) and request review from mconnor.

Comment 11

[Bamm Gabriana]

When I filed Bug 312825, a resolved dupe of this one, my intention was not to
bring back the Forward and Home button text to the default Firefox look, but
just to change the way selective text is implemented. Just as there is good
reason for the default look to have "Selective text", there is also good reason
for the theme "IE Skin" to have "Text and Icons". It should be implemented in a
way that does not break existing themes.