Closed Bug 309386 Opened 19 years ago Closed 19 years ago

Document what a null stream listener from loadImageWithChannel means

Categories

(Core :: Graphics: ImageLib, enhancement)

enhancement
Not set
normal

Tracking

()

RESOLVED FIXED
mozilla1.9alpha1

People

(Reporter: Biesinger, Assigned: Biesinger)

Details

Attachments

(1 file, 1 obsolete file)

LoadImageWithChannel returns NS_OK with a null listener if it has a cached image
for that URL. that should be documented.
Attached patch patch (obsolete) — Splinter Review
Attachment #196842 - Flags: review?(pavlov)
Severity: normal → enhancement
Status: NEW → ASSIGNED
OS: Linux → All
Hardware: PC → All
Target Milestone: --- → mozilla1.9alpha
Attachment #196842 - Flags: review?(pavlov) → review+
Attachment #196842 - Flags: superreview?(bzbarsky)
Comment on attachment 196842 [details] [diff] [review]
patch

sr=bzbarsky, but if we're documenting that the caller doesn't need to cancel,
we should remove the comment in imgLoader that claims the caller ought to.
Attachment #196842 - Flags: superreview?(bzbarsky) → superreview+
Attachment #196842 - Attachment is obsolete: true
Checking in modules/libpr0n/public/imgILoader.idl;
/cvsroot/mozilla/modules/libpr0n/public/imgILoader.idl,v  <--  imgILoader.idl
new revision: 1.13; previous revision: 1.12
done
Checking in modules/libpr0n/src/imgLoader.cpp;
/cvsroot/mozilla/modules/libpr0n/src/imgLoader.cpp,v  <--  imgLoader.cpp
new revision: 1.89; previous revision: 1.88
done
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: