309397 - In Download Manager, the "Cancel" button is in the same place that the "Open" button appears. An intent to Cancel could lead to an unintentional Open.

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, enhancement)

Description

[Chris Nelson]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.7.10) Gecko/20050716 Firefox/1.0.6

If a user tries to cancel a download, especially one of an unknown size, it's
possible that in the time between the brain impulse to click, and when the click
occurs, the download will complete, and the "Cancel" button will now turn into
the "Open" button, in the exact same place. If the user intended to cancel a
dangerous download, then they have now opened it.

Reproducible: Always

Steps to Reproduce:
1. Download something
2. Observe that Cancel turns into Open upon the download's completion
3. Cry

Actual Results:  
Intending to clicking "Cancel" could result in "Open" being clicked.

Expected Results:  
The "Open" button should appear somewhere other than where the "Cancel" button
once was.

Comment 1

[schmees]

The download-entry-lines change in its height depending on its status (downloading or finished) so that trying to click on "open" can result into clicking on "remove" when downloads above that line suddenly have finished.

This problem is analog to the one reported by Chris Nelson. 
It could be fixed if the download-entry-lineheight would always be the same. At the moment the download-status-bar changes the height of the download-entry-line.

Comment 2

[Marco Bonardo [:mak]]

this could be an enhancement

Comment 3

[Ed Lee :Mardak]

Bug 405886 removed the open button so users need to double click to open the file.