309412 - sequence of tests in all.sh is illogical and suboptimal

Status: RESOLVED FIXED

(NSS :: Test, defect, P2)

Description

[Nelson Bolyard (seldom reads bugmail)]

NSS contains code at many levels, from lowest level crypto and database
functions, to higher level stuff, with SSL and S/MIME testing at the 
highest layer.  

It seems logical to test bottom up; that is, to determine that the crypto
algorithms work before testing SSL with them.  
It seems logical to test *basic* cert chain validation before testing that
with CRLs.  
It seems logical to test *basic* SSL first, and then test SSL with CRLs.  

Similarly, a failure of an early test of a low level feature should prevent 
the subsequent testing of higher level features that depend on that lower
level one, but should NOT prevent the subsequent testing of higher level
features that do NOT depend on that lower level one.  An example of where
this is not done right is in the ssl.sh script.  If the CRL setup fails,
then NONE of the SSL testing is done.  A CRL setup failure prevents the
basic SSL testing, which does NOT depend on CRLs at all.

I will shortly attach a patch to this bug that reorders the scripts in 
all.sh to be more bottom up, and that makes the dbtests script no longer
depend unnecessarily on ssl.sh running first.  It will also add stress
testing of SSL FULL handshakes.

This leaves the above cited SSL CRL testing issues to be resolved.

Comment 1

[Nelson Bolyard (seldom reads bugmail)]

P2 for 3.11

Comment 2

[Nelson Bolyard (seldom reads bugmail)]

Attachment: patch to reorder tests bottom up

Julien, please review.

Comment 3

[Nelson Bolyard (seldom reads bugmail)]

Checked in on trunk.  
Checking in all.sh;             new revision: 1.20; previous revision: 1.19
Checking in dbtests/dbtests.sh; new revision: 1.12; previous revision: 1.11
Now watching Tinderbox.