309430 - potential oom crash [@ xptiInterfaceInfoManager::GetInterfaceInfoManagerNoAddRef]

Status: RESOLVED FIXED

(Core :: XPCOM, defect)

Description

[Daniel de Wildt]

71         gInterfaceInfoManager = new xptiInterfaceInfoManager(searchPath);
 72         if(gInterfaceInfoManager)
 73             NS_ADDREF(gInterfaceInfoManager);
 74         if(!gInterfaceInfoManager->IsValid())

If the "new" in line 71 fails, then we will crash in line 74.

Comment 1

[Daniel de Wildt]

Attachment: Add null check

This patch returns nsnull if xptiInterfaceInfoManager could not instantiated.

Comment 2

[Doug Turner (:dougt)]

Comment on attachment 196945 [details] [diff] [review]
Add null check

Lets also add an NS_ERROR above the return.

DougT

Comment 3

[Ryan VanderMeulen [:RyanVM]]

Attachment: Add NS_ERROR to previous patch

Doug, does this error work for you?

Comment 4

[Doug Turner (:dougt)]

Comment on attachment 295697 [details] [diff] [review]
Add NS_ERROR to previous patch

Looks good.

Comment 5

[Reed Loden [:reed]]

Checking in xpcom/reflect/xptinfo/src/xptiInterfaceInfoManager.cpp;
/cvsroot/mozilla/xpcom/reflect/xptinfo/src/xptiInterfaceInfoManager.cpp,v  <--  xptiInterfaceInfoManager.cpp
new revision: 1.61; previous revision: 1.60
done