309433 - [FIX]tr children of tables don't register in the rows collection XHTML

Status: RESOLVED FIXED

(Core :: DOM: Core & HTML, defect, P2)

Description

[Yuh-Ruey Chen]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

tr children of table elements, i.e. tr that aren't inside tbody, thead, or tfoot
elements, aren't in the rows collection.

This is probably related to bug 309431.

Opera 8 has the correct behavior.


Reproducible: Always

Steps to Reproduce:

Comment 1

[Yuh-Ruey Chen]

Attachment: testcase

Comment 2

[Boris Zbarsky [:bzbarsky]]

Attachment: Proposed fix

This basically lists the rows in the following order:

thead
tbodies
orphans (not in table section)
tfoot

As long as a page doesn't mix tbodies and orphan rows, there's no issue, of course.  ;)

Given that the DOM spec doesn't specify order for this collection, I'm perfectly happy with the behavior...

Comment 3

[Jonas Sicking (:sicking) No longer reading bugmail consistently]

Why not instead make the DO_FOR_EACH_ROWGROUP macro provide the rows collection rather then the rowgroup. So something like

 #define DO_FOR_EACH_ROWGROUP(_code)                                  \
   PR_BEGIN_MACRO                                                     \
     if (mParent) {                                                   \
       /* THead */                                                    \
       nsCOMPtr<nsIDOMHTMLTableSectionElement> rowGroup;              \
       rv = mParent->GetTHead(getter_AddRefs(rowGroup));              \
       NS_ENSURE_SUCCESS(rv, rv);                                     \
       nsCOMPtr<nsIDOMHTMLCollection> rows;                           \
       if (rowGroup) {                                                \
         rowGroup->GetRows(getter_AddRefs(rows));                     \
         do { /* gives scoping */                                     \
           _code                                                      \
         } while (0);                                                 \


Then you can simply do

      /* orphan rows */                                              \
      rows = mOrphanRows;                                            \
      do { /* gives scoping */                                       \
        _code                                                        \
      } while (0);                                                   \

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: With that change

Comment 5

[Boris Zbarsky [:bzbarsky]]

Fixed.