309452 - Dropping a tab to another tabbar should drop the URL

Status: RESOLVED FIXED

(Firefox :: Tabbed Browser, defect)

Description

[Dorando]

User-Agent:       Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.7.12) Gecko/20050920 Firefox/1.0.7
Build Identifier: Mozilla/5.0 (Windows; U; Win 9x 4.90; en-US; rv:1.8b4) Gecko/20050919 Firefox/1.4

The drop code as based on miniT was supposed to fall back to standard URL
dropping if the tab wasn't dropped in its own tabbar, but retrieveURLFromData
fails to retrieve a URL since there is none attached to the text/x-moz-tab flavour.

While investigating this, I realized that using an additional flavour is not
needed (but was needed by miniT).

Reproducible: Always

Comment 1

[Dorando]

Attachment: Removing text/x-moz-tab

This patch also removes ondragover and ondragdrop from xul:tabs since they
don't seem to be needed anymore.

Comment 2

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/widgets/tabbrowser.xml; new revision: 1.114;

Comment 3

[Mike Connor [:mconnor]]

not a blocker, but a nice low-risk tweak.

Comment 4

[Frederic Bezies]

Sorry to spam, but does this checkin can "kill" any click on personal toolbar ?

I built a fx including this bugfix, and my personal toolbar is not working when
I click a link on it.

Comment 5

[Adam Guthrie]

Yes. Pretty sure this caused bug 310187.

Comment 6

[:Gavin Sharp [email: [e-mail]]]

(In reply to comment #5)
> Yes. Pretty sure this caused bug 310187.

Just for the record, this bug didn't cause that one.

Comment 7

[Asaf Romano (gone)]

1.8 branch:
Checking in tabbrowser.xml;
/cvsroot/mozilla/toolkit/content/widgets/tabbrowser.xml,v  <--  tabbrowser.xml
new revision: 1.103.2.10; previous revision: 1.103.2.9
done

Comment 8

[Serge Gautherie (:sgautherie)]

For the record, I filed bug 319876 to port this patch to SeaMonkey.