309505 - Switching views in Lightning results in gray screen

Status: RESOLVED FIXED

Description

[Joey Minta]

Whenever a user is already viewing a particular calendar screen and then
switches views, the result is simply a gray screen. Switching from a normal
thunderbird email view works fine.

Comment 1

[Joey Minta]

Created attachment 196932 [details] [diff] [review]
uncollapse the view

The problem is that LtnObserveDisplayDeckChange gets called during the
view-drawing.  However, event.target in this case is the actual view, not the
view-box.  This means it fails to match |if (id == "calendar-view-box")| and so
the view-box gets collapsed.  One solution would be to try and tweak the
addEventListener line, but this solution was just too simple to pass up.

Comment 2

[Dan Mosedale (:dmose)]

Comment on attachment 196932 [details] [diff] [review]
uncollapse the view

I agree that it makes sense to workaround the Gecko bug so that Lightning at
least has a chance of working in versions of TBird that don't have this fix. 
However this fix makes for really non-obvious control flow.  Please fix up the
testing in the listener instead, with comments about the bug being worked
around.

Comment 3

[Joey Minta]

Created attachment 197010 [details] [diff] [review]
modify event listener

version 2 checks to make sure that we have the deck we're actually looking for.

Comment 4

[Dan Mosedale (:dmose)]

Comment on attachment 197010 [details] [diff] [review]
modify event listener

r=dmose; good job tracking this one down!

Comment 5

[Joey Minta]

patch checked in.  As soon as I find some free time, I'll work on writing up the
gecko bug.