309527 - Date is changed to the previous day when updating all day events

Status: RESOLVED FIXED

(Calendar :: General, defect)

Description

[Benny Hill]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050912 Firefox/1.0.6 (Ubuntu package 1.0.6)
Build Identifier: Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.7.10) Gecko/20050912 Firefox/1.0.6 (Ubuntu package 1.0.6)

Whenever I open up an all-day event to update it, the date is changed to the
previous day.  For instance, if I open an event that takes all day on 9/28/2005
as soon as the dialog box opens up the "From" and "To" dates are both set to
9/27/2005.

Reproducible: Always

Steps to Reproduce:
1. Create an all-day event by checking the "All day" checkbox. Save the event.
2. Double click on the event you just created to open it up for editing.
3. From and to dates are now set to the previous day.

Actual Results:  
The "from" and "to" dates are set to the prior day's date.

Expected Results:  
It should not have changed the "from" and "to" dates.

I am using the "sunbird-0.2+.en-US.linux-i686.tar.bz2" binary that I downloaded
on September 21, 2005.

Comment 1

[Joey Minta]

OK, here's what's happening:

All day event scheduled on 9/21 (floating)
event dialog does getInTimezone -> 9/21 (America/New_York)
The .jsDates on these two events are NOT the same, which is our problem.

Confirming for now.  There's probably a dupe of this out there somewhere though.

Comment 2

[Joey Minta]

*** Bug 309545 has been marked as a duplicate of this bug. ***

Comment 3

[Joey Minta]

Blocks 0.3a1.  Fixing this properly is hard.  I'm pretty sure I can hack an ugly
fix for this. mvl and I agree that that's probably the best option, since we're
really close to ready for 0.3a1.

Note that the same underlying problem causes all-day events to not show up in
the day view (after checkin of bug 307344).  Both of these issues are only for
users west of GMT.

Comment 4

[jim garner]

Sorry I did not find the duplicate bug. I did look to the best of my ability.

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: attempt to patch

This patch makes .getInTimezone on a floating datetime return an object that is
still floating. It doesn't have the timezone set.
This means that .jsDate is still the same, so I think this should fix the bug
(but I can't test it, I'm east of gmt)
The idea is that a floating event stays floating. It is not suddenly defined in
some other timezone.

jminta, can you test if this fixes the problems?

Comment 6

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 197084 [details] [diff] [review]
attempt to patch

r=dmose, but i'd like to hear pavlov & shaver's opinions on this also.

Comment 7

[Joey Minta]

Comment on attachment 197084 [details] [diff] [review]
attempt to patch

Fixes things for me! And much prettier than the solution I had in mind.
r=jminta

Comment 8

[jim garner]

It is obvious that I do not know how to test the patch.

When I saw this latest notice I went to...
http://ftp.mozilla.org/pub/mozilla.org/calendar/sunbird/nightly/
...where I scrolled all the way down to...
2005-09-22-08-trunk/               22-Sep-2005 10:40
...but I only found a mac version there, so I went up one directory to the -07...
...and there I found...
sunbird-0.2+.en-US.win32.zip               22-Sep-2005 10:48  5.9M
...I downloaded it, unpacked it and tried it.
it does the same thing!  What am I doing wrong, please?  Since I opened a bug on
this I want to help to fix it or verify it if possible.
Thanx.

Comment 9

[Joey Minta]

(In reply to comment #8)
> It is obvious that I do not know how to test the patch.
> ...I downloaded it, unpacked it and tried it.
> it does the same thing!  What am I doing wrong, please?  Since I opened a bug on
> this I want to help to fix it or verify it if possible.
> Thanx.
> 

You're a bit too eager. :-)  Wait until you see someone say 'Patch checked in'.
 Then, the next nightly that is built after that will have the fix.  The only
other way to test this patch would be to checkout the source code and build
Sunbird yourself, with the corresponding changes.

Comment 10

[Michiel van Leeuwen (email: mvl+moz@)]

shaver, pav: can you look at this patch? (see comment 5 and 6)

Comment 11

[David Brennan]

(In reply to comment #10)
> shaver, pav: can you look at this patch? (see comment 5 and 6)

Has any progress on checking this in been made? I have a very similar problem,
an all-day event shows up on the wrong day on my Linux box, but it is on the
correct day on my windows machine. Both sharing the same remote calendar.

However one additional difference, I do not need to open an event on the linux
box for it to show on the wrong date. This is my .ics file:

BEGIN:VCALENDAR
VERSION:2.0
PRODID:-//Mozilla.org/NONSGML Mozilla Calendar V1.0//EN
BEGIN:VEVENT
CREATED:20051006T000135Z
LAST-MODIFIED:20051006T000156Z
DTSTAMP:20051006T000135Z
UID:uuid1128556916818
SUMMARY:No School
PRIORITY:0
STATUS:
CLASS:PUBLIC
DTSTART;VALUE=DATE:20051004
DTEND;VALUE=DATE:20051005
CATEGORIES:Public Holiday
END:VEVENT
BEGIN:VEVENT
CREATED:20051006T000208Z
LAST-MODIFIED:20051006T000225Z
DTSTAMP:20051006T000208Z
UID:uuid1128556945852
SUMMARY:No School
PRIORITY:0
STATUS:
CLASS:PUBLIC
DTSTART;VALUE=DATE:20051013
DTEND;VALUE=DATE:20051014
CATEGORIES:Public Holiday
END:VEVENT
END:VCALENDAR

The events correctly show up on 10/4 and 10/13 under Windows. But 10/3 and 10/12
in Linux. Both computers are running nightly builds, Windows d/l today, Linux
yesterday.

Comment 12

[Dan Mosedale (:dmosedale, :dmose)]

I talked to Pav a bit, and he didn't sound overly confident and mentioned that
the code is a bit fragile, and it sounds like Shaver probably won't have time to
get back to us on this soon.  So I guess I'd be ok with landing this and just
keeping an eye out for trouble and dealing with it if it crops up...

Comment 13

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in. I'll keep an eye on incoming problems.

Comment 14

[Brock Haywood]

i just rebuilt sunbird with the latest source (checked to make sure i got the
patch) on winxp and i am still experiencing this problem where events that last
all day get moved one day previous when i re-open them. im Pacific timezone. im
not sure what other information would be helpful to help resolve this.

Comment 15

[David Brennan]

(In reply to comment #13)
> patch checked in. I'll keep an eye on incoming problems.

I just downloaded the latest nightly build and noticed the following:
1. All day events do not show up at all in multi-week view.
2. They are displayed off by a day in the event list at the top.
3. In month view, they show up correctly.
4. In weekly view they are early by a day.
5. In daily view they show up correctly.

I am in the pacific time zone.

I have not re-tested the windows version.

By the way is the latest nightly supposed to be available in .bz2 and .gz? only
the .bz2 has the current date.