309534 - Pass a boolean aDidNotify to DoneAddingChildren?

Status: RESOLVED FIXED

(Core :: DOM: HTML Parser, defect)

Description

[Christian :Biesinger (don't email me, ping me on IRC)]

Code added in bug 1156 would benefit from knowing whether the content sink
already notified for the content it created (so that it knows whether it has to
notify or not)

Comment 1

[Olli Pettay [:smaug][[e-mail]]]

Just wondering...
When would the aDidNotify be PR_FALSE, when PR_TRUE?

Just FYI,
I think, XTF (or especially XForms) wouldn't use the parameter for anything.
Atm, it is assumed that BeginAddingChildren is called before adding any attributes
or child nodes, and DoneAddingChildren happens after those. And that
Begin/DoneAddingChildren are called only by ContentSink.

Comment 2

[Christian :Biesinger (don't email me, ping me on IRC)]

it would basically be PR_FALSE if there has not been any attempt to create
frames for this node, PR_TRUE otherwise.

Comment 3

[Boris Zbarsky [:bzbarsky]]

Attachment: Something like this, say

The idea is to use this in applet and object as this patch does.

Comment 4

[Boris Zbarsky [:bzbarsky]]

Attachment: Actually compiling

Comment 5

[Blake Kaplan (:mrbkap) (inactive)]

Comment on attachment 196970 [details] [diff] [review]
Actually compiling

>Index: content/html/document/src/nsHTMLContentSink.cpp
>@@ -1371,21 +1372,37 @@ SinkContext::CloseContainer(const nsHTML
>+    {
>+      PRBool notified = PR_TRUE;
>+      if (0 < mStackPos) {
>+        nsIContent* parent = mStack[mStackPos - 1].mContent;
>+        notified =
>+          mStack[mStackPos-1].mNumFlushed == parent->GetChildCount();
>+      }
>+      content->DoneAddingChildren(notified);
>+    }
...
>+    {
>+      PRBool notified = PR_TRUE;
>+      if (0 < mStackPos) {
>+        nsIContent* parent = mStack[mStackPos - 1].mContent;
>+        notified =
>+          mStack[mStackPos-1].mNumFlushed == parent->GetChildCount();
>+      }
>+      result = mSink->ProcessSCRIPTEndTag(content, notified);
>+    }

Want to break the common code out into a function or a macro or something?

r=mrbkap with that.

Comment 6

[Johnny Stenback (:jst)]

Comment on attachment 196970 [details] [diff] [review]
Actually compiling

sr=jst

Comment 7

[Boris Zbarsky [:bzbarsky]]

Attachment: Updated to review comments

Comment 8

[Boris Zbarsky [:bzbarsky]]

Fixed.