The default bug view has changed. See this FAQ.

Fix a11y problems and crop="right" is deprecated in page info dialog

RESOLVED FIXED

Status

SeaMonkey
Page Info
RESOLVED FIXED
12 years ago
8 years ago

People

(Reporter: Ian Neal, Assigned: Ian Neal)

Tracking

({fixed1.8})

Trunk
fixed1.8
Dependency tree / graph

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(1 attachment, 2 obsolete attachments)

(Assignee)

Description

12 years ago
This bug tidies up after fix to ff bug 217611 also fixes the following:
Focus first selected tab and fix labels to point at readonly text fields
(equivalent of ff bug 303097) and in pageInfo.xul, a deprecated value for the
attribute crop is used.  Instead of "right", the value should be "end"
(equivalent of ff bug 286405)
(Assignee)

Comment 1

12 years ago
Created attachment 196951 [details] [diff] [review]
three-in-one patch v0.1

This patch:
* Removes FF specific code from pki's PageInfoOverlay.xul which also removes
the need to preprocess that file
* Tweaks code in navigator.js and pageinfo.js so that the above file works with
them
* Changes crop="right" to crop="end" in pageinfo.xul
* Adds control attributes to relevant lines in pageinfo.xul
* Focuses on first selected tab
Assignee: db48x → iann_bugzilla
Status: NEW → ASSIGNED
Attachment #196951 - Flags: review?(db48x)
(Assignee)

Updated

12 years ago
Depends on: 217611, 286405, 303097

Comment 2

12 years ago
In PageInfoOverlay.xul, you probably should change the variable "w" to be named
"doc" and the associated comments since it's always going to be a document now.
(Assignee)

Comment 3

12 years ago
w is not just used for a document, can also be a contentwindow or a frame.
Comment on attachment 196951 [details] [diff] [review]
three-in-one patch v0.1

looks good, r=db48x
Attachment #196951 - Flags: review?(db48x) → review+
(Assignee)

Updated

12 years ago
Attachment #196951 - Flags: superreview?(neil.parkwaycc.co.uk)

Comment 5

12 years ago
Comment on attachment 196951 [details] [diff] [review]
three-in-one patch v0.1

>+          w = window.arguments[0].doc;
> 
>           // We don't have separate info for a frame, return null until further notice
>           // (see bug 138479)
>           return null;
It hardly seems worth assigning to w in this case.

>-        <textbox class="header" readonly="true" crop="right" id="titletext"/>
>+        <textbox class="header" readonly="true" crop="end" id="titletext"/>
Nit: crop is meaningless on <textbox>es; they were probably converted from
<text>s or <labels>.

>-        <text id="metahead" class="header" value="&generalMeta;"/>
>+        <text id="metahead" control="metatree" class="header" value="&generalMeta;"/>
You can't put control= on <text>s, but these should probably be <label>s
anyway.

sr=me with these nits fixed.
Attachment #196951 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Assignee)

Comment 6

12 years ago
Created attachment 198081 [details] [diff] [review]
Label and no crop patch v0.1a

Changes since v0.1:
* Added extra fix required for extension/p3p's pageInfoOverlay.js for new
argument arrangement for pageInfo.xul
* Removed unneeded crops from <textbox>es
* Changed <text> to <label> and tweaked css to indent labels as before.

Carrying forward r= and asking for confirming sr=
Attachment #196951 - Attachment is obsolete: true
Attachment #198081 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #198081 - Flags: review+
(Assignee)

Updated

12 years ago
Attachment #198081 - Flags: superreview?(neil.parkwaycc.co.uk)
(Assignee)

Comment 7

12 years ago
Created attachment 198172 [details] [diff] [review]
The one with the jar patch v0.1b (Checked in trunk and branch)

Changes since v0.1a:
* Added missing diff to jar.mn in security/manager/pki/resources (thanks for
spotting Neil)
Attachment #198081 - Attachment is obsolete: true
Attachment #198172 - Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #198172 - Flags: review+

Updated

12 years ago
Attachment #198172 - Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
(Assignee)

Comment 8

12 years ago
Comment on attachment 198172 [details] [diff] [review]
The one with the jar patch v0.1b (Checked in trunk and branch)

Checking in
extensions/p3p/resources/content/pageInfoOverlay.js;
new revision: 1.5; previous revision: 1.4
security/manager/pki/resources/jar.mn;
new revision: 1.47; previous revision: 1.46
security/manager/pki/resources/content/PageInfoOverlay.xul;
new revision: 1.23; previous revision: 1.22
xpfe/browser/resources/content/navigator.js;
new revision: 1.580; previous revision: 1.579
xpfe/browser/resources/content/pageInfo.js;
new revision: 1.75; previous revision: 1.74
xpfe/browser/resources/content/pageInfo.xul;
new revision: 1.58; previous revision: 1.57
themes/classic/navigator/pageInfo.css;
new revision: 1.9; previous revision: 1.8
themes/modern/navigator/pageInfo.css;
new revision: 1.8; previous revision: 1.7
done
Attachment #198172 - Attachment description: The one with the jar patch v0.1b → The one with the jar patch v0.1b (Checked in)
(Assignee)

Updated

12 years ago
Status: ASSIGNED → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED
(Assignee)

Comment 9

12 years ago
Comment on attachment 198172 [details] [diff] [review]
The one with the jar patch v0.1b (Checked in trunk and branch)

Requesting a= for simple, fairly low risk, suite version of FF patch that went
onto the branch
Attachment #198172 - Flags: approval1.8b5?

Comment 10

12 years ago
Comment on attachment 198172 [details] [diff] [review]
The one with the jar patch v0.1b (Checked in trunk and branch)

approving this suite only change but please land this ASAP, the approval could
be removed later on.
Attachment #198172 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Comment 11

12 years ago
Comment on attachment 198172 [details] [diff] [review]
The one with the jar patch v0.1b (Checked in trunk and branch)

Checking in (branch)
extensions/p3p/resources/content/pageInfoOverlay.js;
new revision: 1.3.28.1; previous revision: 1.3
security/manager/pki/resources/jar.mn;
new revision: 1.45.4.2; previous revision: 1.45.4.1
security/manager/pki/resources/content/PageInfoOverlay.xul;
new revision: 1.20.20.3; previous revision: 1.20.20.2
xpfe/browser/resources/content/navigator.js;
new revision: 1.577.2.3; previous revision: 1.577.2.2
xpfe/browser/resources/content/pageInfo.js;
new revision: 1.73.2.2; previous revision: 1.73.2.1
xpfe/browser/resources/content/pageInfo.xul;
new revision: 1.57.4.1; previous revision: 1.57
themes/classic/navigator/pageInfo.css;
new revision: 1.8.18.1; previous revision: 1.8
themes/modern/navigator/pageInfo.css;
new revision: 1.7.18.1; previous revision: 1.7
done
Attachment #198172 - Attachment description: The one with the jar patch v0.1b (Checked in) → The one with the jar patch v0.1b (Checked in trunk and branch)
(Assignee)

Updated

12 years ago
Keywords: fixed1.8
You need to log in before you can comment on or make changes to this bug.