Closed
Bug 309542
Opened 19 years ago
Closed 19 years ago
Fix a11y problems and crop="right" is deprecated in page info dialog
Categories
(SeaMonkey :: Page Info, defect)
SeaMonkey
Page Info
Tracking
(Not tracked)
RESOLVED
FIXED
People
(Reporter: iannbugzilla, Assigned: iannbugzilla)
References
Details
(Keywords: fixed1.8)
Attachments
(1 file, 2 obsolete files)
20.71 KB,
patch
|
iannbugzilla
:
review+
neil
:
superreview+
mscott
:
approval1.8b5+
|
Details | Diff | Splinter Review |
This bug tidies up after fix to ff bug 217611 also fixes the following: Focus first selected tab and fix labels to point at readonly text fields (equivalent of ff bug 303097) and in pageInfo.xul, a deprecated value for the attribute crop is used. Instead of "right", the value should be "end" (equivalent of ff bug 286405)
This patch: * Removes FF specific code from pki's PageInfoOverlay.xul which also removes the need to preprocess that file * Tweaks code in navigator.js and pageinfo.js so that the above file works with them * Changes crop="right" to crop="end" in pageinfo.xul * Adds control attributes to relevant lines in pageinfo.xul * Focuses on first selected tab
Comment 2•19 years ago
|
||
In PageInfoOverlay.xul, you probably should change the variable "w" to be named "doc" and the associated comments since it's always going to be a document now.
w is not just used for a document, can also be a contentwindow or a frame.
Comment 4•19 years ago
|
||
Comment on attachment 196951 [details] [diff] [review] three-in-one patch v0.1 looks good, r=db48x
Attachment #196951 -
Flags: review?(db48x) → review+
Attachment #196951 -
Flags: superreview?(neil.parkwaycc.co.uk)
Comment 5•19 years ago
|
||
Comment on attachment 196951 [details] [diff] [review] three-in-one patch v0.1 >+ w = window.arguments[0].doc; > > // We don't have separate info for a frame, return null until further notice > // (see bug 138479) > return null; It hardly seems worth assigning to w in this case. >- <textbox class="header" readonly="true" crop="right" id="titletext"/> >+ <textbox class="header" readonly="true" crop="end" id="titletext"/> Nit: crop is meaningless on <textbox>es; they were probably converted from <text>s or <labels>. >- <text id="metahead" class="header" value="&generalMeta;"/> >+ <text id="metahead" control="metatree" class="header" value="&generalMeta;"/> You can't put control= on <text>s, but these should probably be <label>s anyway. sr=me with these nits fixed.
Attachment #196951 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Changes since v0.1: * Added extra fix required for extension/p3p's pageInfoOverlay.js for new argument arrangement for pageInfo.xul * Removed unneeded crops from <textbox>es * Changed <text> to <label> and tweaked css to indent labels as before. Carrying forward r= and asking for confirming sr=
Attachment #196951 -
Attachment is obsolete: true
Attachment #198081 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #198081 -
Flags: review+
Attachment #198081 -
Flags: superreview?(neil.parkwaycc.co.uk)
Changes since v0.1a: * Added missing diff to jar.mn in security/manager/pki/resources (thanks for spotting Neil)
Attachment #198081 -
Attachment is obsolete: true
Attachment #198172 -
Flags: superreview?(neil.parkwaycc.co.uk)
Attachment #198172 -
Flags: review+
Updated•19 years ago
|
Attachment #198172 -
Flags: superreview?(neil.parkwaycc.co.uk) → superreview+
Comment on attachment 198172 [details] [diff] [review] The one with the jar patch v0.1b (Checked in trunk and branch) Checking in extensions/p3p/resources/content/pageInfoOverlay.js; new revision: 1.5; previous revision: 1.4 security/manager/pki/resources/jar.mn; new revision: 1.47; previous revision: 1.46 security/manager/pki/resources/content/PageInfoOverlay.xul; new revision: 1.23; previous revision: 1.22 xpfe/browser/resources/content/navigator.js; new revision: 1.580; previous revision: 1.579 xpfe/browser/resources/content/pageInfo.js; new revision: 1.75; previous revision: 1.74 xpfe/browser/resources/content/pageInfo.xul; new revision: 1.58; previous revision: 1.57 themes/classic/navigator/pageInfo.css; new revision: 1.9; previous revision: 1.8 themes/modern/navigator/pageInfo.css; new revision: 1.8; previous revision: 1.7 done
Attachment #198172 -
Attachment description: The one with the jar patch v0.1b → The one with the jar patch v0.1b (Checked in)
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Comment on attachment 198172 [details] [diff] [review] The one with the jar patch v0.1b (Checked in trunk and branch) Requesting a= for simple, fairly low risk, suite version of FF patch that went onto the branch
Attachment #198172 -
Flags: approval1.8b5?
Comment 10•19 years ago
|
||
Comment on attachment 198172 [details] [diff] [review] The one with the jar patch v0.1b (Checked in trunk and branch) approving this suite only change but please land this ASAP, the approval could be removed later on.
Attachment #198172 -
Flags: approval1.8b5? → approval1.8b5+
Assignee | ||
Comment 11•19 years ago
|
||
Comment on attachment 198172 [details] [diff] [review] The one with the jar patch v0.1b (Checked in trunk and branch) Checking in (branch) extensions/p3p/resources/content/pageInfoOverlay.js; new revision: 1.3.28.1; previous revision: 1.3 security/manager/pki/resources/jar.mn; new revision: 1.45.4.2; previous revision: 1.45.4.1 security/manager/pki/resources/content/PageInfoOverlay.xul; new revision: 1.20.20.3; previous revision: 1.20.20.2 xpfe/browser/resources/content/navigator.js; new revision: 1.577.2.3; previous revision: 1.577.2.2 xpfe/browser/resources/content/pageInfo.js; new revision: 1.73.2.2; previous revision: 1.73.2.1 xpfe/browser/resources/content/pageInfo.xul; new revision: 1.57.4.1; previous revision: 1.57 themes/classic/navigator/pageInfo.css; new revision: 1.8.18.1; previous revision: 1.8 themes/modern/navigator/pageInfo.css; new revision: 1.7.18.1; previous revision: 1.7 done
Attachment #198172 -
Attachment description: The one with the jar patch v0.1b (Checked in) → The one with the jar patch v0.1b (Checked in trunk and branch)
You need to log in
before you can comment on or make changes to this bug.
Description
•