Remove non-ASCII characters in JSS sources

RESOLVED FIXED in 4.1.1

Status

Product:
JSS
Component:
Library
RESOLVED FIXED
Reported:
13 years ago
Modified:
13 years ago

People

(Reporter: Wan-Teh Chang, Assigned: Wan-Teh Chang)

Tracking

Target:
4.1.1

Details

Attachments

(1 attachment)

Proposed patch
720 bytes, patch
glen beasley
: review+
Details | Diff | Splinter Review
(Assignee)

Description

•
13 years ago 
mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java
contains the non-ASCII character α (decimal value 224) in
the following comment, which breaks compilation under IBM JDK.

    /**
     * A bag containing a private key encrypted α la PKCS #8.  The bag
     * content is a PKCS #8 <i>EncryptedPrivateKeyInfo</i>.
     */
    public static final OBJECT_IDENTIFIER PKCS8_SHROUDED_KEY_BAG =
            PKCS12_BAG_IDS.subBranch(2);
(Assignee)

Comment 1

•
13 years ago 
Created attachment 197048 [details] [diff] [review]
Proposed patch

The non-ASCII character is the French accented a (à).
Attachment #197048 - Flags: review?(glen.beasley)
(Assignee)

Comment 2

•
13 years ago 
I scanned all the files under mozilla/security/jss
on the JSS trunk and JSS_3_X_BRANCH.
mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java
is the only text file that contains a non-ASCII character.
Status: NEW → ASSIGNED

Comment 3

•
13 years ago 
Comment on attachment 197048 [details] [diff] [review]
Proposed patch

r+
Attachment #197048 - Flags: review?(glen.beasley) → review+
(Assignee)

Comment 4

•
13 years ago 
Patch checked in on the JSS trunk and JSS_3_X_BRANCH.
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1.1
You need to log in before you can comment on or make changes to this bug.