Closed Bug 309640 Opened 20 years ago Closed 20 years ago

Remove non-ASCII characters in JSS sources

Categories

(JSS Graveyard :: Library, defect)

defect
Not set
normal

Tracking

(Not tracked)

RESOLVED FIXED

People

(Reporter: wtc, Assigned: wtc)

Details

Attachments

(1 file)

mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java contains the non-ASCII character α (decimal value 224) in the following comment, which breaks compilation under IBM JDK. /** * A bag containing a private key encrypted α la PKCS #8. The bag * content is a PKCS #8 <i>EncryptedPrivateKeyInfo</i>. */ public static final OBJECT_IDENTIFIER PKCS8_SHROUDED_KEY_BAG = PKCS12_BAG_IDS.subBranch(2);
Attached patch Proposed patchSplinter Review
The non-ASCII character is the French accented a (à).
Attachment #197048 - Flags: review?(glen.beasley)
I scanned all the files under mozilla/security/jss on the JSS trunk and JSS_3_X_BRANCH. mozilla/security/jss/org/mozilla/jss/pkcs12/SafeBag.java is the only text file that contains a non-ASCII character.
Status: NEW → ASSIGNED
Comment on attachment 197048 [details] [diff] [review] Proposed patch r+
Attachment #197048 - Flags: review?(glen.beasley) → review+
Patch checked in on the JSS trunk and JSS_3_X_BRANCH.
Status: ASSIGNED → RESOLVED
Closed: 20 years ago
Resolution: --- → FIXED
Target Milestone: --- → 4.1.1
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Creator:
Created:
Updated:
Size: