309661 - remove "DiscRecording 2.1.17f1" from .dmg file

Status: RESOLVED WONTFIX

(Firefox Build System :: General, defect)

Description

[Jo Hermans]

When you expand a Mac .dmg file, you first get an (optional) license agreement,
then you get a dialog box when the archive is checked for errors. In Firefox
1.5b1, but also in Thunderbird 1.5b1 and the latest Camino, you can see the
following text (the same for all 3 products) :

Checksumming DiscRecording 2.1.17f1 (Apple_HFS : 1)...

DiscRecording 2.1.17f1 is probably the name of the archive that was used to make
the .dmg file. It used to be a different name, but it was changed about a month
ago, when the license agreement and background was added.

Yesterday I was approached by some collegues that wanted to know what Firefox
was doing with their disk. It seems that they misunderstood the message, and
didn't know what checksumming was (they're not technical and English is not
their mothertongue). They also saw 'Disc' and 'Recording', and it somehow
frightened them. And they also didn't recognize the versionnumber, and were
thinking that they now installed the wrong version.

It's not the most important thing, but Mento mentioned that he has a way to
change that name.

Comment 1

[Jo Hermans]

Attachment: example

Comment 2

[Mark Mentovai]

"DiscRecording blah" is the name given in the partition table to the slice that
contains the filesystem.  It SHOULD, and usually does, match the volume name. 
When hdiutil makehybrid is used to prepare a disk image, DiscRecording winds up
there instead.

The name in the partition table doesn't affect anything and is only infrequently
displayed.  The verification operation when mounting a dmg is one of the few
times it shows its ugly face.  The message used to say, and should say,
"Checksumming Firefox (Apple_HFS : 1)".

To fix this, the name in the partition table can be edited to match the volume
name.  This involves piping a few commands to "pdisk" while the image is
attached but its filesystems unmounted.  It's pretty easy to fix in the
packager, and I think we should do it, to avoid frightening Jo's coworkers.

Comment 3

[Mark Mentovai]

The offending message only appears on Jaguar and earlier, which use Disk Copy as
the image mounting helper.  Panther and later use a "built-in" helper which
displays a "Verifying" message without the slice name.

Comment 4

[Jo Hermans]

(In reply to comment #3)
> The offending message only appears on Jaguar and earlier, which use Disk Copy as
> the image mounting helper.  Panther and later use a "built-in" helper which
> displays a "Verifying" message without the slice name.

Well, in that case ... feel free to mark this as WONTFIX, if it would seem a
waste of time. There are more important things to do.

Comment 5

[Mark Mentovai]

10.2 only, not worth fixing.