309690 - images with funny names won't upload

Status: RESOLVED WORKSFORME

(SeaMonkey :: General, defect)

Description

[Dave Dyer]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.11) Gecko/20050728
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.7.11) Gecko/20050728

using the browser FILE upload, images whose names include some unspecified
set of unusual characters will not upload.  It appears that they are reported
as application-data/octet and their content is not uploaded.

for example, try an image named !@#$%^&_()_.jpg which is perfectly legal
in windows.

Reproducible: Always

Steps to Reproduce:
1. pick an image
2. upload to any normally acceptable recepient
3.

Actual Results:  
depends on the recepient, but it doesn't work.  


my hacked up version of readparse reports these tags at the crucial point,
and the upload fails to produce a useful result because the file has no data.

RP: multipart heads:
Content-Disposition: form-data; name="upfile"; filename="!@#$%^&_()_.jpg"
Content-Type: application/octet-stream

RP: ctype application/octet-stream name !@#$%^&_()_.jpg
RP: type jpg
RP: opened g:/apache/temp//cgi-lib-1127432828-192.168.0.10-4675-4184-1.jpg
RP: buf 49
RP: got(2) 0 of 0
RP: closing, len=0
readparse = 10


where the evil "internet explorer" browser supplies these (and works)
RP: multipart heads:
Content-Disposition: form-data; name="upfile";
filename="G:\share\images\nametestpc\!@#$%^&ƒo()_.jpg" Content-Type: image/pjpeg

RP: ctype image/pjpeg name G:\share\images\nametestpc\!@#$%^&ƒo()_.jpg
RP: type jpg
RP: opened g:/apache/temp//cgi-lib-1127432997-192.168.0.10-4707-4440-1.jpg
RP: buf 8160
RP: got(2) 132 of 132
RP: got(3) 8192

RP: got(3) 8192

RP: got(3) 8192

Comment 1

[OstGote!]

see the other bugs
https://bugzilla.mozilla.org/buglist.cgi?query_format=advanced&short_desc_type=allwordssubstr&short_desc=fil+nam+upload&product=Core&product=Firefox&product=Mozilla+Application+Suite&long_desc_type=substring&long_desc=&bug_file_loc_type=allwordssubstr&bug_file_loc=&status_whiteboard_type=allwordssubstr&status_whiteboard=&keywords_type=allwords&keywords=&resolution=---&emailassigned_to1=1&emailtype1=exact&email1=&emailassigned_to2=1&emailreporter2=1&emailqa_contact2=1&emailtype2=exact&email2=&bugidtype=include&bug_id=&votes=&chfieldfrom=&chfieldto=Now&chfieldvalue=&cmdtype=doit&order=Reuse+same+sort+as+last+time&field0-0-0=noop&type0-0-0=noop&value0-0-0=

Comment 2

[Boris Zbarsky [:bzbarsky]]

Martijn, can you reproduce this on Windows?

Comment 3

[Martijn Wargers (dead)]

(In reply to comment #2)
> Martijn, can you reproduce this on Windows?
No, tried it with current trunk build, with a 20060118 build and Mozilla1.7.12. All work for me.
I tried it on http://software.hixie.ch/utilities/cgi/data/data

Comment 4

[Serge Gautherie (:sgautherie)]

MozillaAS v1.7.x is not supported anymore.

Dave,
Can you reproduce with SeaMonkey v1.1.9 ?

Comment 5

[Dave Dyer]

This seems to have been fixed somewhere in the last few years

Comment 6

[Jason Bassford]

No bug / patch referenced as the code fix.