Closed Bug 309796 Opened 19 years ago Closed 19 years ago

Whining needs to check for shutdown (silently) before trying database access

Categories

(Bugzilla :: Whining, defect)

Product:
Bugzilla
Component:
Whining
Version:
2.21
Type:
defect
Priority:
Not set
Severity:
normal

Tracking

()

Status:
RESOLVED FIXED
Milestone:
Bugzilla 2.22

People

(Reporter: bugreport, Assigned: LpSolit)

References

Details

Attachments

(1 file, 2 obsolete files)

patch, v3
1.89 KB, patch
bugreport
: review+
Details | Diff | Splinter Review 
Whining will still get noisey if the database is stopped even if shutdownhtml is
set.
Attached patch patch, v1 (obsolete) — — Splinter Review 

  

  


Assignee: erik → LpSolit
Status: NEW → ASSIGNED

        Attachment #197364 -
        Flags: review?(bugreport)

    
  
Target Milestone: --- → Bugzilla 2.22

    
    

    
  
Comment on attachment 197364 [details] [diff] [review]
patch, v1

Still doesn't get it in time.  You need to move the check up above the "require
globals" line and it needs to be preceded by the use Bugzilla::Config line.

To test this, change your localconfig to have a bad password value.

  

  



        Attachment #197364 -
        Flags: review?(bugreport) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v2 (obsolete)
        — 
          — Splinter Review
      

    


  
I think this is the cleanest solution, independently on how whine.pl behaves
relatively to this patch.

  

  



        Attachment #197364 -
        Attachment is obsolete: true

        Attachment #197459 -
        Flags: review?(bugreport)

    
    

    
  
*** Bug 309402 has been marked as a duplicate of this bug. ***

  

  



    
    

    
  
Comment on attachment 197459 [details] [diff] [review]
patch, v2

This is certainly the right approach, but it does not work.  Try setting
shutdownhtml and also messing up localconfig's database username and you'll see
the failure.

  

  



        Attachment #197459 -
        Flags: review?(bugreport) → review-

    
    

    
  

      
      
      
      

        Attached patch
          
          
        patch, v3
        — 
          — Splinter Review
      

    


  

  

  



        Attachment #197459 -
        Attachment is obsolete: true

        Attachment #197614 -
        Flags: review?(bugreport)

    
    

    
  
Comment on attachment 197614 [details] [diff] [review]
patch, v3

OK, this works...  as a seperate matter, we still should do something more
graceful when the database is unreachable and cgis attempt to access.

  

  



        Attachment #197614 -
        Flags: review?(bugreport) → review+

    
  
Flags: approval?
Flags: approval? → approval+

    
    

    
  
Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.20; previous revision: 1.19
done
Checking in whine.pl;
/cvsroot/mozilla/webtools/bugzilla/whine.pl,v  <--  whine.pl
new revision: 1.17; previous revision: 1.16
done


  

  


Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED

          You need to log in
          before you can comment on or make changes to this bug.
        






  

    
  







  

    

      
Attachment

      

      
      
      
      
    

    

      

        

          

            
General

            

              Creator: 



            

            
Created: 

            
Updated: 

            
Size: