309802 - JavaScript "onclick" doesn't function Hallmark website

Status: RESOLVED DUPLICATE of bug 309712

(Core :: JavaScript Engine, defect)

Description

[Emanuel Ravelli]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050923 Camino/1.0a1+
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b5) Gecko/20050923 Camino/1.0a1+

On page
<http://www.hallmark.com/webapp/wcs/stores/servlet/ECardPersonalizeView?s=nfg2130&sn=Couldn%27t+Sleep&ssd=Couldn%27t+Sleep&st=%2Fproducts%2Fecards%2Fnfg2130_120.gif&mid=-1002&f=false&r=&p=&n=&e=&date=&eo=true&nv=true&ss=http%3A%2F%2Fwww.hallmark.com%2Fwebapp%2Fwcs%2Fstores%2Fservlet%2FECardConfirmationView&sf=ECardPersonalizeView&pers=false&catalogId=10051&storeId=10001&productId=144986&categoryId=&CatIDsList=-2%3B-102001%3B11446%3B-102034&partNumber=>,
JavaScript buttons don't function. Other browsers recognized the JavaScript
action   correctly.

Reproducible: Always

Steps to Reproduce:
1. Go to URL above.
2. Click on "Preview E-Card" button (or "Send").

Actual Results:  
Browser doesn't react. Nothing. Nada. Zilch.

Expected Results:  
Execute JavaScript action <onclick="javascript:submitECard>.

Comment 1

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Indeed.  A recent Fx branch nightly works.

onclick doesn't get fired in selects (bug 258445), but this (based on the
testcase in bug 258445) works:

<input type="button" value="Click Me!" onclick="alert('onClick Event')">

So there must be something more complex going on at Hallmark with the
javascript: part of onclick.

Comment 2

[Simon Fraser [no longer active]]

The preview button works fine for me in 1.0a1.

Comment 3

[Emanuel Ravelli]

Interesting. Using Version 2005092304 (1.0a1+), cookies allowed or disallowed,
the problem is still with there. (6:16 PM, September 23, 2005)

Comment 4

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

OK, here's the deal.  This broke between Camino 2005092104 and Camino 2005092204.  

Regression window: 
http://tinyurl.com/b8s7w (only changes touching module Camino) 
http://tinyurl.com/cpecn (all files in repository)

It's also broken in Firefox; worked the 21st, didn't work the 23rd, didn't test
the 22nd.

From the things checked in that touch Camino, it looks like Brendan and Blake
touched JS-y things, but my reading of those bugs doesn't make either seem likely.

I didn't see anything that looked to me like a dupe; 
I also don't have a good idea where this goes in Core, so choosing Core:DOM and
offering apologies.  

Comment 5

[Brendan Eich [:brendan]]

http://www.hallmark.com/wcsstore/HallmarkStore/javascript/common_scripts.js
wrongly includes HTML comment hiding hacks meant for inline script tag content,
to hide JS from pre-JS browsers.

/be

*** This bug has been marked as a duplicate of 309712 ***

Comment 6

[Bob Clary [:bc] (inactive)]

(In reply to comment #5)

It is fairly common for people to include <!-- --> in external js files.

Comment 7

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Clearing my blocking? flag.