Closed
Bug 309844
Opened 19 years ago
Closed 19 years ago
Suppress ++/--DOMWINDOW debug spew by default
Categories
(Core :: DOM: Core & HTML, defect)
Core
DOM: Core & HTML
Tracking
()
RESOLVED
WONTFIX
mozilla1.9alpha1
People
(Reporter: darin.moz, Assigned: darin.moz)
References
Details
Attachments
(1 file)
|
2.48 KB,
patch
|
jst
:
review+
jst
:
superreview+
|
Details | Diff | Splinter Review |
In an effort to make the console output of a debug build less noisly, I'd like to make the ++/--DOMWINDOW spew use NSPR logging.
|
Assignee | |
Comment 1•19 years ago
|
||
Attachment #197239 -
Flags: superreview?(jst)
Attachment #197239 -
Flags: review?(jst)
|
|
Assignee | |
Updated•19 years ago
|
Target Milestone: --- → mozilla1.9alpha
|
||
Comment 2•19 years ago
|
||
Comment on attachment 197239 [details] [diff] [review] v1 patch -#ifdef DEBUG - printf("++DOMWINDOW == %d\n", gRefCnt); -#endif I fully understand that most people don't want to see this, but I do. Please change that to #ifdef DEBUG_jst instead of removing it, and add the LOG() too if you want to... :)
Attachment #197239 -
Flags: superreview?(jst)
Attachment #197239 -
Flags: superreview+
Attachment #197239 -
Flags: review?(jst)
Attachment #197239 -
Flags: review+
|
|
Assignee | |
Comment 3•19 years ago
|
||
jst: see also bug 309845, where it seems dbaron similarly objects to this kind of change. re: "#ifdef DEBUG_jst", why not just add "NSPR_LOG_MODULES=domwindow:5" to your environment? then, you get basically the same thing without having to modify the code.
Depends on: 309845
|
|
Assignee | |
Comment 4•19 years ago
|
||
dbaron said that he was strongly against this, so i'm going to close it as WONTFIX
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → WONTFIX
You need to log in
before you can comment on or make changes to this bug.
Description
•