309914 - insertBefore doesn't work correctly for children of an XBL binding with non-empty content

Status: RESOLVED FIXED

Description

[Nickolay_Ponomarev]

If I have a binding with content like this:
    <content>
      <xul:label value="anon label"/>
      <children/>
    </content>

..bound to a box with a few children (button0, button1, etc), then insertBefore
doesn't work properly. For example if I do:
  var item = container.firstChild;
  container.insertBefore(item.nextSibling, item); // shouldn't modify anything

The box's contents becomes: button1, <anon label>, button0, button2, ...
Although DOMi indicates that the tree is not modified.

Moving <children> to be before the label "fixes" the problem. Removing
<children> altogether doesn't, although the displayed order is different.

Filing this under XBL, since I only can reproduce it using a binding with
content. Tested using 20050923, 1.8 branch. This happens with Firefox 1.0 too.

Comment 1

[Nickolay_Ponomarev]

Created attachment 197294 [details]
testcase

Click the "click me" button to test.

Comment 2

[Stephen Donner [:stephend]]

DUP of bug 56758?

Comment 3

[Boris Zbarsky [:bzbarsky, bz on IRC]]

More likely a dup of bug 272646

Comment 4

[Boris Zbarsky [:bzbarsky, bz on IRC]]

Fixed by checkin for bug 307394.  Added the test to reftest.