309916 - Editing mime-type handlers fails with a missing handler

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Phil Ringnalda (:philor)]

If you have a mime-type handler that no longer exists, the View & Edit
Actions... dialog throws when it tries to get the display name, and doesn't show
any actions at all.

STR:
1. Click http://philringnalda.com/mtests/handlergone/hard.cheese
2. In the dialog, select Open with, Browse to a program you don't mind moving,
and check Do this automatically...
3. Change either the filename, or any part of the path, for the program you used
in step 2.
4. Open Tools/Options/Downloads, and click View & Edit Actions...
5. The dialog is blank, and the jsconsole says "Error: uncaught exception:
[Exception... "Component returned failure code: 0x80520012
(NS_ERROR_FILE_NOT_FOUND) [nsILocalFileWin.getVersionInfoField]"  nsresult:
"0x80520012 (NS_ERROR_FILE_NOT_FOUND)"  location: "JS frame ::
chrome://browser/content/preferences/downloadactions.js :: anonymous :: line
251"  data: no]"

After customHandler.initWithPath(externalAppPath); we need to be sure
customHandler exists.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: patch

Comment 2

[Phil Ringnalda (:philor)]

Attachment: patch v.2

gavin sez: don't put it in the try{} if you don't need it in the try{}.

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/browser/components/preferences/downloadactions.js; new revision: 1.7;

Comment 4

[Donald Bock]

*** Bug 310016 has been marked as a duplicate of this bug. ***

Comment 5

[Scott MacGregor]

Comment on attachment 197298 [details] [diff] [review]
patch v.2

approving this very low risk change.

Comment 6

[Asaf Romano (gone)]

1.8 branch:
Checking in downloadactions.js;
/cvsroot/mozilla/browser/components/preferences/downloadactions.js,v  <-- 
downloadactions.js
new revision: 1.5.2.1; previous revision: 1.5
done

Comment 7

[Donald Bock]

YES, IT IS FIXED.