Created attachment 197319 [details] [diff] [review] patch Since bug 301738, if the string contains a time HH:MM without seconds, the next number will be treated as the seconds which in this case will result in the year being treated as seconds. By protecting the assignment to sec with the prevc value of ':', we prevent this from happening. This is the regression. The second issue is if a '(' follows a number without an intervening space, a syntax error occurs in Mozilla but IE does not treat it as such. This will make "Sep 24, 11:58 pm(ET) 105" and "Sep 24, 11:58 pm (ET) 105" both valid dates. This is wallpaper, but I'm not sure I want to try to do more.
RCS file: /cvsroot/mozilla/js/tests/js1_5/Date/regress-309925-01.js,v done Checking in regress-309925-01.js; /cvsroot/mozilla/js/tests/js1_5/Date/regress-309925-01.js,v <-- regress-309925-01.js initial revision: 1.1 done RCS file: /cvsroot/mozilla/js/tests/js1_5/Date/regress-309925-02.js,v done Checking in regress-309925-02.js; /cvsroot/mozilla/js/tests/js1_5/Date/regress-309925-02.js,v <-- regress-309925-02.js initial revision: 1.1 done
Comment on attachment 197319 [details] [diff] [review] patch Gross, but I guess it falls under Postel's rule. /be
Comment on attachment 197319 [details] [diff] [review] patch r=mrbkap, well caught!
Checking in jsdate.c; /cvsroot/mozilla/js/src/jsdate.c,v <-- jsdate.c new revision: 3.71; previous revision: 3.70 done 2005-09-26 21:10 bob%bclary.com mozilla/ js/ src/ jsdate.c 3.71 2/2 Bug 309925, fix regression in parsing dates containing HH:MM caused by bug 301738, r=mrbkap, sr=brendan
Comment on attachment 197319 [details] [diff] [review] patch Seeking approval for 1.8b5 for this simple, low risk fix to a regression.
2005-09-27 19:35 bob%bclary.com mozilla/ js/ src/ jsdate.c 126.96.36.199 MOZILLA_1_8_BRANCH 2/2 Bug 309925, fix regression in parsing dates containing HH:MM caused by bug 301738, r=mrbkap, sr=brendan, a=asa
v ff 188.8.131.52, 1.5, 1.6 20060217 win/linux/mac