310054 - IHtmlImgElement interface implementation

Status: RESOLVED INVALID

(Core Graveyard :: Embedding: ActiveX Wrapper, enhancement)

Description

[Alexandre Trémon]

I implemented the complete, width, height (get), src (get/put) properties.

Comment 1

[Alexandre Trémon]

Attachment: implementation

Comment 2

[Alexandre Trémon]

VB test code:

Private Sub Command1_Click()
    Dim doc2 As IHTMLDocument2
    Set doc2 = MozillaBrowser1.Document
    Dim coll As IHTMLElementCollection
    Set coll = doc2.All.tags("img")
    Dim img As IHTMLImgElement
    Set img = coll.Item(0)
    Dim l As Long
    l = img.Height
    l = img.Width
    Dim s As String
    s = img.src
    Dim b As Boolean
    b = img.complete
End Sub

Private Sub Form_Load()
    MozillaBrowser1.Navigate "www.mozilla.org"
    
End Sub

Comment 3

[Alexandre Trémon]

Comment on attachment 197409 [details] [diff] [review]
implementation

Adam, can you review this for me? IHtmlImgElement is defined in the 98 SDK.

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Apologies, I hit the wrong button :(

Comment 5

[Alexandre Trémon]

Comment on attachment 197409 [details] [diff] [review]
implementation

Hi Benjamin.
Could you review this for me?

Thank you!

Comment 6

[Benjamin Smedberg]

Comment on attachment 197409 [details] [diff] [review]
implementation

Hrm, what are all the E_NOTIMPL methods? Is it a good idea to have a half-implemented interface?

Comment 7

[Alexandre Trémon]

Hi benjamin,

Actually, for most interfaces I implemented I left methods unimplemented. Three of these partially implemented interfaces are checked in: DomNode, ButtonElement and TxtRange. Others are waiting for VS7 SDK, like IMarkup, and I have some others I didn't open a bug for. But if you look at Adam's work, IHtmlElement is only partially implemented.
The goal for me is simply provide the methods I need to begin with, and so there is a framwork for others who would simply want to implement one method without going through the hassle of trying to get something like this checked in.
For some interfaces, I also have the main methods implemented for initial check in, and I put some rather complicated methods in another bug.

Alex

Comment 8

[Benjamin Smedberg]

Comment on attachment 197409 [details] [diff] [review]
implementation

As we discussed on email a long time ago, I don't like the piecemeal approach.

Comment 9

[Ed Morley [:emorley]]

The ActiveX embedding API was removed in bug 662023 and friends, making this INVALID.

[Filter bugspam on activexinvalid]