310070 - runtests.pl reports errors when the 'shutdownhtml' parameter is turned on

Status: RESOLVED FIXED

(Bugzilla :: Testing Suite, defect)

Description

[Frédéric Buclin]

An administrator may decide to shut down Bugzilla while hacking the code, and
could also want to run runtests.pl before reactivating Bugzilla in order to make
sure he didn't do errors. But runtests.pl whines that he should do another job
(i.e. reports a full list of errors). :( This is annoying because the only way
to run runtests.pl correctly is to reactivate Bugzilla before being sure
everything is fine.

Comment 1

[Marc Schumann [:Wurblzap]]

Attachment: Patch

Comment 2

[Frédéric Buclin]

Comment on attachment 204538 [details] [diff] [review]
Patch

This patch fixes the problem, but I want a second review.

This patch needs to be backported to 2.20.

Comment 3

[Frédéric Buclin]

(In reply to comment #2)
> This patch needs to be backported to 2.20.

err... sorry, 2.20 is not affected.

Comment 4

[Max Kanat-Alexander]

Comment on attachment 204538 [details] [diff] [review]
Patch

No... just put the script in SHUTDOWNHTML_EXEMPT.

Comment 5

[Max Kanat-Alexander]

Comment on attachment 204538 [details] [diff] [review]
Patch

OK, yes, that looks good.

The comment is unclear, though -- make it more specific.

Nit: You don't need to add a whole new line for $^C. You can just keep it on the same line as Param("shutdownhtml").

Comment 6

[Marc Schumann [:Wurblzap]]

Ok, the comment will read on check-in like this:

# Because this is code which is run live from perl "use" commands of other
# scripts, we're skipping this part if we get here during a perl syntax check
# -- runtests.pl compiles scripts without running them, so we need to make sure
# that this check doesn't apply to 'perl -c' calls.

Comment 7

[Marc Schumann [:Wurblzap]]

Checking in Bugzilla.pm;
/cvsroot/mozilla/webtools/bugzilla/Bugzilla.pm,v  <--  Bugzilla.pm
new revision: 1.26; previous revision: 1.25
done