310111 - Milestone::check_milestone and similar subroutines should return a generic error

Status: RESOLVED WONTFIX

(Bugzilla :: Bugzilla-General, defect)

Description

[Greg Hendricks]

Currently they simply throw a user error. This makes it less than desireable for
non cgi scripts such as importxml.pl. This means if an invalid milestone is
passed, control exits the calling script and is taken over by the Template code.

It should instead return an error code and the calling code should handle it.

Comment 1

[Joel Peshkin]

Look at Bugzilla->batch

If set to one, it will keep the Throw*Error functions from exiting so they can
be called from within an eval to field these sorts of errors.  Does that cover
your application?

Comment 2

[Greg Hendricks]

How do I set it to 1?

Comment 3

[Frédéric Buclin]

I guess this bug should be more generic and involve all .pm modules. Maybe
should ThrowUserError() check whether i_am_cgi() is true or false, and return
the error message accordingly, i.e. with or without HTML.

Comment 4

[Greg Hendricks]

I have set the batch to 1 and used evals but it still seems to be a not very elegent solution. 

Comment 5

[Frédéric Buclin]

(In reply to comment #4)
> I have set the batch to 1 and used evals but it still seems to be a not very
> elegent solution. 
> 

That's the solution I used in bug 174039 and it's working fine. Not really elegant, I agree but this works for now.

Comment 6

[Greg Hendricks]

Bugzilla ERROR_MODES makes this moot.