310162 - Changing proxy settings is slow and throws multiple javascript errors

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dave Townsend [:mossop]]

Changing the proxy settings throws the following message lots of times:

Error: document has no properties
Source File: chrome://global/content/bindings/preferences.xml
Line: 94

Don't seem to be able to reproduce this on branch.

Comment 1

[Dave Townsend [:mossop]]

Silly me, my branch install didnt have console logging. This does occur on branch.

Comment 2

[Dave Townsend [:mossop]]

Attachment: Re-registers preference observer as necessary

When child prefwindows are accepted, they create preference elements in the
parent to hold their state. Unfortunatly these elements have a blank name and
so the preference observer is called once for every one of these elements,
everytime a preference changes.

This patch re-registers the preference observer when the preference element's
name changes. It might also be sensible to do some other things on preference
name change, retrieve the value from preferences perhaps?

I confess to not being totally sure what is causing the specific error message,
but it happens at the same time as the pref observer being called about 10
times for the same preference, and this patch seems to resolve it for me.

Comment 3

[Mike Connor [:mconnor]]

Comment on attachment 197587 [details] [diff] [review]
Re-registers preference observer as necessary

another example of making the widget better before people really start using it

Comment 4

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/widgets/preferences.xml; new revision: 1.40;

Comment 5

[Scott MacGregor]

gavin, this needs to get i nASAP or the approval may go away. 

Comment 6

[:Gavin Sharp [email: [e-mail]]]

I probably won't be able to check this in today. Asaf, do you mind checking this
in on the branch?

Comment 7

[Dave Townsend [:mossop]]

Forgot to mark this, timeless checked it in a short while ago.