Closed Bug 310171 Opened 19 years ago Closed 19 years ago

Update css for private comments in real-time

Categories

(Bugzilla :: User Interface, enhancement, P2)

2.21
enhancement

Tracking

()

RESOLVED FIXED
Bugzilla 2.22

People

(Reporter: bugreport, Assigned: batosti)

References

Details

Attachments

(1 file, 1 obsolete file)

The bz_private style is used to display private comments.  If the status of the
checkbox is changed, the style for the display should change immediately.

Also, the same fomatting can be applied to the comment textarea depending on the
status of the private checkbox above the textarea.
Attached patch batosti_v1 (obsolete) β€” β€” Splinter Review
Attachment #197608 - Flags: review?(myk)
Well, this works great in Firefox, but IE loses its styles for private
everything.  I think there is a bit more javascripot magic needed to make it
work cross-browser.

Comment on attachment 197608 [details] [diff] [review]
batosti_v1

Patch needs some extra javascript magic to work with ie (and not regress)
Attachment #197608 - Flags: review?(myk) → review-
Also, while we are at it, attachment entry and edit should probably do the same
thing.
Assignee: myk → batosti
Attachment #197608 - Attachment is obsolete: true
Attachment #198524 - Flags: review?(bugreport)
Priority: -- → P2
Target Milestone: --- → Bugzilla 2.22
Comment on attachment 198524 [details] [diff] [review]
batosti_v1_fix: working on ie

neat!!!  r=joel
Attachment #198524 - Flags: review?(bugreport) → review+
There is one javascript complaint that doesn't bother anything in FF and seems
to be required to work with IE.  The document.refresh function seems to be an
ie-only hack.
Flags: approval?
Flags: approval? → approval+

Checking in template/en/default/bug/comments.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/comments.html.tmpl,v
 <--  comments.html.tmpl
new revision: 1.21; previous revision: 1.20
done
Checking in template/en/default/bug/edit.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/bug/edit.html.tmpl,v  <--
  edit.html.tmpl
new revision: 1.64; previous revision: 1.63
done
Status: NEW → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Keywords: relnote
The New Attachment page isn't changing the css class in real time.
Status: RESOLVED → REOPENED
Resolution: FIXED → ---
Status: REOPENED → RESOLVED
Closed: 19 years ago19 years ago
Resolution: --- → FIXED
Blocks: 314548
Added to the Bugzilla 2.22 Release Notes in bug 322960.
Keywords: relnote
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: