310194 - Change events can get fired multiple times for preference elements

Status: RESOLVED FIXED

(Firefox :: Settings UI, defect)

Description

[Dave Townsend [:mossop]]

In some situations since bug 308966 preference elements can receive change
events twice for the same change and can also receive change events when no
change has occured.

Comment 1

[Dave Townsend [:mossop]]

Attachment: Cleanup event firing

This changes the setter to check for an actual change of value before firing
the event. It also moves the event fire to be in just one place to stop it
getting called twice.

Comment 2

[Mike Connor [:mconnor]]

Comment on attachment 197584 [details] [diff] [review]
Cleanup event firing

we should get this in on branch ASAP, this is a new widget we should get as
clean as we can...

Comment 3

[:Gavin Sharp [email: [e-mail]]]

Trunk:
mozilla/toolkit/content/widgets/preferences.xml; new revision: 1.41;

Comment 4

[Scott MacGregor]

gavin, this needs to get i nASAP or the approval may go away. 

Comment 5

[:Gavin Sharp [email: [e-mail]]]

I probably won't be able to check this in today. Asaf, do you mind checking this
in on the branch?

Comment 6

[Dave Townsend [:mossop]]

Forgot to mark this, timeless checked it in a short while ago.