310266 - drawing artifacts in small buttons

Status: RESOLVED WORKSFORME

(Camino Graveyard :: HTML Form Controls, defect)

Description

[Eizan Miyamoto]

User-Agent:       Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050914 Camino/1.0a1
Build Identifier: Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.8b4) Gecko/20050914 Camino/1.0a1

in http://groups.yahoo.com/, when clicking & holding the mouse over the 'sign
in' button, then dragging it off, some drawing artifacts get left behind from
when the button was activated.

Reproducible: Always

Steps to Reproduce:
1. set your "Proportional (serif)" font to arial 12pt
2. access http://groups.yahoo.com
3. click & hold your mouse button on the 'sign in' button
4. drag the pointer off the button

Actual Results:  
some minor drawing artifacts were left behind at the bottom area of the button.
It appears that only the sub-region of the button that the text area occupied is
refreshed.

Expected Results:  
the button cleanly redrawn with no artifacts from when the button was selected

Comment 1

[Eizan Miyamoto]

Attachment: this is what the button looks like after you perform the click & drag

This a screen grab that contains an image of the button with artifacts after I
clicked the button, but then dragged the pointer off of it.

Comment 2

[Eizan Miyamoto]

Version 2005091409 (1.0a1)

Comment 3

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Aside from the focus ring, I see the little bit of Aqua-blue left over at the
bottom in 10.3.9, too--simply clicking on the button and releasing (i.e.,
actually submitting the form) will cause it.

I think it may have to do with styled buttons (incl. text size), though, since
the "Commit" button here in Bugzilla does not have the problem while the "Find"
button at the bottom of the bug does.

Comment 4

[Samuel Sidler (old account; do not CC)]

I'm not sure the setting of the font matters at all, does it? It looks like
Yahoo! Groups sets the font to Arial on that form button.

That said, using 1.0a1 on Tiger, I don't see this at all.

Reporter, were you on Panther (like Smokey was)?

Comment 5

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Have to be on 10.4.x to get focus rings on buttons....

Comment 6

[Eizan Miyamoto]

Attachment: my browser preferences

Comment 7

[Eizan Miyamoto]

yes, I'm running 10.4.2

I thought it might be the minimum font size, so I disabled it. However, it
didn't change anything. ymmv.

Comment 8

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Testcase with some styles, pulled from Bugzilla and Yahoo Groups

Having a border specified on the <input type="submit"> seems to be the worst
offender from the Yahoo styles, but specifying a smaller font-size is part of
the problem (as is font-family, though only if either of the other two are
already specified).

Comment 9

[Samuel Sidler (old account; do not CC)]

Since we get form controls from widget/cocoa, should this block 1.8b5?

Requesting blocking, but Simon should have a look to be sure.

(Drivers, please let a Mac widget person look at this before minusing.)

Comment 10

[Josh Aas]

This should not block 1.8b5.

Comment 11

[Asa Dotzler [:asa]]

minus, per Josh.

Comment 12

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

Attachment: Cut-off commit button

I occasionally see the bottoms of buttons cut-off, too (like the commit button below), when they appear (not when clicking).  It might be related to this--except I don't see it all the time, so it's partially a painting issue(?)

Maybe when the button is hidden when the tab paints and then is scrolled into view?

Comment 13

[Smokey Ardisson (offline for a while; not following bugs - do not email)]

See also smfr's bug 153572 comment 15.

Comment 14

[Stuart Morgan]

It's gone on trunk (not least because the styles that caused the worst problems now cause fallback to styled buttons). To the extent that it would still be around though, it would have been fixed by the theme frame changes.

Closing WFM since it's a combination of changes.