310268 - Feed autodiscovery needs to support mime-type params (by ignoring them)

Status: VERIFIED FIXED

(Firefox Graveyard :: RSS Discovery and Preview, defect)

Description

[Phil Ringnalda (:philor)]

Oops. Apparently nobody involved in specifying RSS and Atom autodiscovery quite
noticed the fact that since there's no name for a mime-type |type "/" subtype|
production exclusive of "media-type" which is |type "/" subtype *( ";" parameter
)|, we weren't actually saying that autodiscovery demands exactly
|type="application/atom+xml"|, since |type="application/atom+xml; charset=utf"|
is also a perfectly correct Atom media-type. Testcase and patch shortly.

Comment 1

[Phil Ringnalda (:philor)]

Attachment: testcase

Comment 2

[Phil Ringnalda (:philor)]

Attachment: patch v.1

Also fixes an unnoticed bug in the harvestFeeds "hide duplicates and stuff"
routine, which was getting the raw mime-type, rather than a case-normalized and
trimmed version.

Comment 3

[Asa Dotzler [:asa]]

can we get this landed on the trunk and verified there to make sure we don't
break anything and that this solves the problem? After a trunk landing and
verification we'll consider for the branch.

Comment 4

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Checking in mozilla/browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.516; previous revision: 1.515
done

Comment 5

[Marcia Knous [:marcia]]

verified using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1)
Gecko/20050930 Firefox/1.6a1. test case works like a charm.

Comment 6

[Asaf Romano (gone)]

1.8 branch:
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.37; previous revision: 1.479.2.36
done

Comment 7

[Tanner M. Young [:tmyoung]]

Resetting QA Contact to default.