Feed autodiscovery needs to support mime-type params (by ignoring them)

VERIFIED FIXED in Firefox1.5

Status

()

Firefox
RSS Discovery and Preview
VERIFIED FIXED
13 years ago
9 years ago

People

(Reporter: philor, Assigned: philor)

Tracking

({fixed1.8})

Trunk
Firefox1.5
fixed1.8
Points:
---

Firefox Tracking Flags

(Not tracked)

Details

Attachments

(2 attachments)

(Assignee)

Description

13 years ago
Oops. Apparently nobody involved in specifying RSS and Atom autodiscovery quite
noticed the fact that since there's no name for a mime-type |type "/" subtype|
production exclusive of "media-type" which is |type "/" subtype *( ";" parameter
)|, we weren't actually saying that autodiscovery demands exactly
|type="application/atom+xml"|, since |type="application/atom+xml; charset=utf"|
is also a perfectly correct Atom media-type. Testcase and patch shortly.
(Assignee)

Updated

13 years ago
Status: NEW → ASSIGNED
Flags: blocking1.8b5?
Target Milestone: --- → Firefox1.5
(Assignee)

Comment 1

13 years ago
Created attachment 197667 [details]
testcase
(Assignee)

Comment 2

13 years ago
Created attachment 197668 [details] [diff] [review]
patch v.1

Also fixes an unnoticed bug in the harvestFeeds "hide duplicates and stuff"
routine, which was getting the raw mime-type, rather than a case-normalized and
trimmed version.
Attachment #197668 - Flags: review?(mconnor)

Updated

13 years ago
Attachment #197668 - Flags: review?(mconnor) → review+
(Assignee)

Updated

13 years ago
Whiteboard: [checkin needed]
(Assignee)

Updated

13 years ago
Attachment #197668 - Flags: approval1.8b5?

Comment 3

13 years ago
can we get this landed on the trunk and verified there to make sure we don't
break anything and that this solves the problem? After a trunk landing and
verification we'll consider for the branch.
Checked in on trunk

Checking in mozilla/browser/base/content/browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.516; previous revision: 1.515
done
Status: ASSIGNED → RESOLVED
Last Resolved: 13 years ago
Resolution: --- → FIXED
(Assignee)

Updated

13 years ago
Whiteboard: [checkin needed]
verified using Mozilla/5.0 (Macintosh; U; PPC Mac OS X Mach-O; en-US; rv:1.9a1)
Gecko/20050930 Firefox/1.6a1. test case works like a charm.
Status: RESOLVED → VERIFIED

Updated

13 years ago
Attachment #197668 - Flags: approval1.8b5? → approval1.8b5+
(Assignee)

Updated

13 years ago
Whiteboard: [checkin needed][a+]
1.8 branch:
Checking in browser.js;
/cvsroot/mozilla/browser/base/content/browser.js,v  <--  browser.js
new revision: 1.479.2.37; previous revision: 1.479.2.36
done
Keywords: fixed1.8
Whiteboard: [checkin needed][a+]
(Assignee)

Updated

13 years ago
Flags: blocking1.8b5?
Resetting QA Contact to default.
QA Contact: nobody → rss.preview
You need to log in before you can comment on or make changes to this bug.