310270 - requiredFeatures switch mistakenly reports support for full Text module

Status: RESOLVED FIXED

(Core :: SVG, defect)

Description

[Doug Schepers]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

When using the 'switch' element with the requiredFeatures string for the Text
Module, FF1.5b1 reports that it is implemented. However, at least 2 important
elements of the Text Module are not implemented in FF1.5b1: 'tref' and
'textPath' (although 'textPath' is implemented in the trunk). Additionally,
baseline-shift does not work (see
https://bugzilla.mozilla.org/show_bug.cgi?id=308338).

Instead, MozillaSVG should only report 'true' to the requiredFeatures string for
the BasicText module, which includes only the 'text' element (even though MozSVG
does implement 'tspan' as well).



Reproducible: Always

Steps to Reproduce:
1. Observe the attached file which shows a 'switch' statement using various
requiredFeatures strings
2. Look for the supported features for SVG1.1
3. See that both "Text" and "BasicText" report as supported.

Actual Results:  
Both "Text" and "BasicText" report as supported.

Expected Results:  
Only the "BasicText" module should report as supported.

Comment 1

[Doug Schepers]

Attachment: switch with requiredFeatures strings

Comment 2

[Jonathan Watt [:jwatt]]

doug:
http://lxr.mozilla.org/seamonkey/source/content/svg/content/src/nsSVGFeaturesList.h

Comment 3

[Boris Zbarsky [:bzbarsky]]

That testcase gives me:

  1.1, Text: No.

with a current trunk build....

Comment 4

[Boris Zbarsky [:bzbarsky]]

This bug was actually fixed (by the patch for bug 294517) 5 days after 1.8b4 shipped (and two weeks before the bug was filed).