310318 - IME composition string isn't rendered as selection text

Status: VERIFIED FIXED

(Core :: Layout: Text and Fonts, defect)

Description

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

IME composition string isn't renderd as selection text.
This is regression on 27 build. 26 build doesn't have this problem.
Is this regression of bug 307875? This bug chenged nsTextFrame.cpp.

This bug is blocker for Japanese testers.

Comment 1

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

On Camino, it's reproduced too.

Comment 2

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

This bug is regression of bug 307875. I tested without the patch.

Comment 3

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

from Japanese tester(VYV03354):

He said that this caused by nsTextFrame::SetSelected.
http://bonsai.mozilla.org/cvsblame.cgi?file=mozilla/layout/generic/nsTextFrame.cpp&rev=1.526#3657

rbs:

Can we remove early return from nsTextFrame::SetSelected?

# Sorry I don't have much time, I'm working on some regressions in 1.8 branch.

Comment 4

[Wevah (Nate Weaver)]

-> All/All since it happens on Camino also (though I haven't yet checked it myself).

Comment 5

[rbs]

Fixed by disabling the early return that was added in nsTextFrame::SetSelected.

Comment 6

[Masayuki Nakano [:masayuki] (he/him)(JST, +0900)]

-> v.