310368 - remove incorrect configuration in JSS_SSLServer.java

Status: RESOLVED FIXED

(JSS Graveyard :: Tests, defect)

Description

[glen beasley]

see bug:

https://bugzilla.mozilla.org/show_bug.cgi?id=310260

Comment 1

[Sandeep Konchady]

Attachment: In JSS_SSLserver removed cient only and fortezza ciphers.

As per Nelson's recommendations I have removed client only (DH and DHE) ciphers from JSS_SSLServer.java and also any references to Fortezza.

Comment 2

[Alexei Volkov]

Comment on attachment 211407 [details] [diff] [review]
In JSS_SSLserver removed cient only and fortezza ciphers.

ClassServer:
* unprotected between threads serverSocket and supportedCiphers variables. 

*Logistic of the function is not quite understood: each time server gets connection it creates a new thread to accept more client connections. At the same time if server successfully read from stream it closes connection with client socket, and start listen for more connections with client. Looks like a bug in program logic to me.

JSS_SSLClient: 
*not quite sure why test force handshake. It should happen when SSLSocket encountered first the bite in a stream. But if forceHandshake is used, we can do better job identifying the completion of handshake by using thread monitors instead of sleep(1000).

* Since forseHandshake is nonblocking, there is race condition created for variable "handshakeCompleted" should be fixed.

*socket.close() was removed. Why?

Comment 3

[Sandeep Konchady]

Attachment: Modified the source as per Alexei's comments

Based on Alexei's comments modified the code with the following changes.

[1] Removed ClassServer.java and added the code to accept() and communicate using JSSE_SSLServer.java
[2] This eliminates ambiguious situation with the logic as well as added thread protection
[3] In JSS_SSLClient removed forceHandshake() which also eliminates race condition
[4] Added socket.close()

Comment 4

[glen beasley]

Comment on attachment 212166 [details] [diff] [review]
Modified the source as per Alexei's comments

some of the lines in 
JSSE_SSLServer go past the 
80 column limit. please fix, but otherwise looks 
good.

Comment 5

[Sandeep Konchady]

Checking in org/mozilla/jss/tests/GenerateTestCert.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/GenerateTestCert.java,v  <--  GenerateTestCert.java
new revision: 1.5; previous revision: 1.4
done
Checking in org/mozilla/jss/tests/JSSE_SSLServer.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/JSSE_SSLServer.java,v  <--  JSSE_SSLServer.java
new revision: 1.8; previous revision: 1.7
done
Checking in org/mozilla/jss/tests/JSS_SSLClient.java;
/cvsroot/mozilla/security/jss/org/mozilla/jss/tests/JSS_SSLClient.java,v  <--  JSS_SSLClient.java
new revision: 1.7; previous revision: 1.6
done