Closed
Bug 310372
Opened 19 years ago
Closed 19 years ago
Suppress updater UI if updater.ini not found
Categories
(Toolkit :: Application Update, defect)
Tracking
()
RESOLVED
FIXED
mozilla1.8final
People
(Reporter: darin.moz, Assigned: darin.moz)
Details
(Keywords: fixed1.8)
Attachments
(1 file, 1 obsolete file)
|
5.51 KB,
patch
|
jaas
:
review+
benjamin
:
superreview+
asa
:
approval1.8b5+
|
Details | Diff | Splinter Review |
Suppress updater UI if updater.ini not found This provides an easy way to enable sysadmins to apply patches silently. See docs here: http://wiki.mozilla.org/Software_Update:Manually_Installing_a_MAR_file
|
Assignee | |
Updated•19 years ago
|
Status: NEW → ASSIGNED
Flags: blocking1.8b5?
Target Milestone: --- → Firefox1.5
|
|
Assignee | |
Comment 1•19 years ago
|
||
Simple patch. For the OSX version, I just moved the ReadStrings call up earlier, and made it so that we error out of the ShowProgressUI call. That's sufficient to instruct updater.cpp to proceed without UI. For the Windows version, it was not convenient to move reading of the strings into ShowProgressUI since I'm not using the ReadStrings function on Windows. So, I added a simple call to the "_access" function defined in io.h.
Attachment #197775 -
Flags: review?(joshmoz)
|
|
Assignee | |
Comment 2•19 years ago
|
||
This is the same patch w/ some additional changes to progressui_gtk.cpp to allow it to run when there is no X11 display. I think this change will come in handy as well.
Attachment #197775 -
Attachment is obsolete: true
Attachment #197785 -
Flags: review?(joshmoz)
|
|
Assignee | |
Updated•19 years ago
|
Attachment #197775 -
Flags: review?(joshmoz)
|
||
Updated•19 years ago
|
Flags: blocking1.8b5? → blocking1.8b5+
Comment on attachment 197785 [details] [diff] [review] v1.1 patch I couldn't actually test on all platforms, but from looking over the patch it looks good. r=josh
Attachment #197785 -
Flags: superreview?(bugs)
Attachment #197785 -
Flags: review?(joshmoz)
Attachment #197785 -
Flags: review+
|
|
Assignee | |
Comment 4•19 years ago
|
||
Comment on attachment 197785 [details] [diff] [review] v1.1 patch changing SR to bsmedberg since he's been involved with this code before.
Attachment #197785 -
Flags: superreview?(bugs) → superreview?(benjamin)
|
||
Updated•19 years ago
|
Attachment #197785 -
Flags: superreview?(benjamin) → superreview+
|
|
||
Updated•19 years ago
|
Attachment #197785 -
Flags: approval1.8b5+
|
|
Assignee | |
Comment 5•19 years ago
|
||
fixed-on-trunk, fixed1.8
|
||
Comment 6•19 years ago
|
||
Sorry to spam this bug, but could it be related to both bug 310686 and bug 310688 which are both crashing on start (for Win32 and OS-X)
|
|
Assignee | |
Comment 7•19 years ago
|
||
Frederic, Thanks for the info. I'll look into it.
|
||
Updated•16 years ago
|
Product: Firefox → Toolkit
You need to log in
before you can comment on or make changes to this bug.
Description
•