Closed Bug 310374 Opened 19 years ago Closed 19 years ago

strict warning in updates.js

Categories

(Toolkit :: Application Update, defect)

defect
Not set
normal

Tracking

()

VERIFIED FIXED
mozilla1.8.1

People

(Reporter: Peter6, Assigned: whimboo)

References

Details

Attachments

(1 file)

Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b5) Gecko/20050928
Firefox/1.4 ID:2005092815

Check for updates
JSC:
Warning: trailing comma is not legal in ECMA-262 object initializers
Source file: chrome://mozapps/content/update/updates.js
Line: 1482, Column: 0
Source code:
}; 

1481    gUpdates.wiz.getButton("finish").focus();
1482   }, 
1483 };

should be ;
same for the lines nr:
454
1345
1454
Blocks: 296661
I'll take a look at these warnings. Btw. js strict warnings wont be fixed for
1.8. So this should happen on trunk.
Status: NEW → ASSIGNED
OS: Windows 2000 → All
Hardware: PC → All
Version: 1.5 Branch → Trunk
Attached patch PatchSplinter Review
Assignee: nobody → hskupin
Attachment #197878 - Flags: review?(benjamin)
Attachment #197878 - Flags: review?(benjamin) → review+
Whiteboard: [checkin needed]
Trunk: mozilla/toolkit/mozapps/update/content/updates.js; new revision: 1.51;
Status: ASSIGNED → RESOLVED
Closed: 19 years ago
Resolution: --- → FIXED
Whiteboard: [checkin needed]
Target Milestone: --- → Firefox1.6-
Status: RESOLVED → VERIFIED
Product: Firefox → Toolkit
You need to log in before you can comment on or make changes to this bug.

Attachment

General

Created:
Updated:
Size: