310403 - global styles should define label.text-link styles

Status: RESOLVED FIXED

(SeaMonkey :: Themes, defect)

Description

[alexander :surkov (:asurkov)]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

Now styles for <label class="text-link"/> is holded in
chrome://communicator/skin/formatting.css. I guess it shuld be available when I
include chrome://global/skin styles only.

When I use text-link label in application then sometimes I can't be depended on
communicator styles. Threafore I guess styles looking like a link should be
reachable from global styles.

Reproducible: Always

Comment 1

[Nickolay_Ponomarev]

I don't think this is a problem anymore, is it? I see the binding defined in xul.css, and the skin styles it in formatting.css, which is included from global.css

Comment 2

[alexander :surkov (:asurkov)]

(In reply to comment #1)
> I don't think this is a problem anymore, is it? I see the binding defined in
> xul.css, and the skin styles it in formatting.css, which is included from
> global.css
> 

Is it true for firefox, but failed for seamonkey. Probably we should change component for the bug.

Comment 3

[Nickolay_Ponomarev]

Please go ahead (or suggest the appropriate product/component). I have no idea where Seamonkey theme bugs go or whether it's an issue there.

Comment 4

[[e-mail]]

(In reply to comment #0)
>I can't be depended on communicator styles.
Offhand I don't see why you can't include communicator's formatting.css

Comment 5

[alexander :surkov (:asurkov)]

(In reply to comment #4)
> (In reply to comment #0)
> >I can't be depended on communicator styles.
> Offhand I don't see why you can't include communicator's formatting.css
> 

Please take a look at bug 309246, I guess xforms shouldn't depend on communicator. even because as far as I know if I use XULRunner then communicator can be absent.

Comment 6

[[e-mail]]

OK, I can see the utility, even if that's a bad example.

Comment 7

[alexander :surkov (:asurkov)]

Attachment: patch

Neil, please look at the patch. I'm not sure all things go right but I tried to figure out where communicator's formatting.css is used and replaced links on global's formatting.css.

Comment 8

[[e-mail]]

Comment on attachment 228687 [details] [diff] [review]
patch

>+  color : purple;
Nit: although previous style was to line up all the :s in all the style rules, current style is to have no spaces before the : at all.

Comment 9

[alexander :surkov (:asurkov)]

Attachment: patch2

(In reply to comment #8)
> (From update of attachment 228687 [details] [diff] [review] [edit])
> >+  color : purple;
> Nit: although previous style was to line up all the :s in all the style rules,
> current style is to have no spaces before the : at all.
> 

Fixed.

I need person who can do super review. Neil, please help me with that.

Comment 10

[jag (Peter Annema)]

Comment on attachment 228949 [details] [diff] [review]
patch2

Marking Neil's r+, adding my sr+

Comment 11

[alexander :surkov (:asurkov)]

Can the bug be checked in on branch?

Comment 12

[[e-mail]]

Fix checked in to the trunk.

(In reply to comment #11)
>Can the bug be checked in on branch?
Unfortunately there are two problems:
1. SeaMonkey doesn't have a Themes component, so you can't move this bug to the right product to gain an approval-seamonkey1.1a flag
2. The branch approval-1.8.1 flag is restricted due to the FF/TB beta releases
So all you can do is to ask nicely in #seamonkey for someone to approve it.

Comment 13

[alexander :surkov (:asurkov)]

(In reply to comment #12)
> Fix checked in to the trunk.
> 
> (In reply to comment #11)
> >Can the bug be checked in on branch?
> Unfortunately there are two problems:
> 1. SeaMonkey doesn't have a Themes component, so you can't move this bug to the
> right product to gain an approval-seamonkey1.1a flag
> 2. The branch approval-1.8.1 flag is restricted due to the FF/TB beta releases
> So all you can do is to ask nicely in #seamonkey for someone to approve it.
> 

Ok. Thank you for check in.