310421 - Updates fail due to missing hash

Status: RESOLVED FIXED

(Toolkit :: Add-ons Manager, defect)

Description

[Daniel Veditz [:dveditz]]

Since bug 306478 landed updates fail since none of the update rdf files yet
specify the hash. The hash should be optional. Enforced if it's present, of
course, but not required as that breaks existing update sites.

See bug 306478 comment 13.

reason for the failure, backend looks for null as "no hash", a blank string is
interpreted as a malformed hash (that is, asserting that the calling code
*intended* a hash check).

Comment 1

[Robert Strong (they/them - no direct email)]

Attachment: patch

Thought I had this already... that's what I get for thinking.

Daniel - could you take a look at this as well?

Comment 2

[Daniel Veditz [:dveditz]]

Comment on attachment 197824 [details] [diff] [review]
patch

sr=dveditz

I flop/flip about every 30 seconds whether nsXPITriggerInfo ought to treat ""
and null the same. This patch is good, it works regardless of what we decide in
xpinstall.

Comment 3

[Robert Strong (they/them - no direct email)]

Checked in on trunk

Checking in mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in;
/cvsroot/mozilla/toolkit/mozapps/extensions/src/nsExtensionManager.js.in,v  <--
 nsExtensionManager.js.in
new revision: 1.159; previous revision: 1.158
done
Checking in mozilla/toolkit/mozapps/extensions/content/update.js;
/cvsroot/mozilla/toolkit/mozapps/extensions/content/update.js,v  <--  update.js
new revision: 1.20; previous revision: 1.19
done

Comment 4

[Asa Dotzler [:asa]]

Comment on attachment 197824 [details] [diff] [review]
patch

please land this on the branch along with bug 306478. thanks.

Comment 5

[Robert Strong (they/them - no direct email)]

Checked in along with the patch in bug 306478