310497 - SB0.2+ will not import a recurring event made from SB0.2

Status: RESOLVED FIXED

(Calendar :: Provider: Local Storage, defect)

Description

[mperanelli]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050927 Mozilla Sunbird/0.2+

I can not import a calendar with recuuring events I made with Sunbird 0.2 into
Sunbird 0.2+  The calendar works fine on Sunbird 0.2

I get the following errors:

Error: flushItem DB error: not an error
Source File:
file:///C:/Program%20Files/Mozilla%20Sunbird/components/calStorageCalendar.js
Line: 1446

Error: [Exception... "Component returned failure code: 0x80004005
(NS_ERROR_FAILURE) [calIRecurrenceRule.endDate]"  nsresult: "0x80004005
(NS_ERROR_FAILURE)"  location: "JS frame ::
file:///C:/Program%20Files/Mozilla%20Sunbird/components/calStorageCalendar.js ::
anonymous :: line 1660"  data: no]
Source File:
file:///C:/Program%20Files/Mozilla%20Sunbird/components/calStorageCalendar.js
Line: 1660

Error: uncaught exception: [Exception... "Component returned failure code:
0x80004005 (NS_ERROR_FAILURE) [calIRecurrenceRule.endDate]"  nsresult:
"0x80004005 (NS_ERROR_FAILURE)"  location: "JS frame ::
file:///C:/Program%20Files/Mozilla%20Sunbird/components/calStorageCalendar.js ::
anonymous :: line 1660"  data: no]


Reproducible: Always

Steps to Reproduce:
1.Select a calendar to import the file to
2.Go to file>import
3.select calendar (didn't know how to put the actual calendar on here, but here
is one recurring event, sorry for the long post.)

BEGIN:VCALENDAR
VERSION
 :2.0
PRODID
 :-//Mozilla.org/NONSGML Mozilla Calendar V1.0//EN
BEGIN:VEVENT
UID
 :87a1161c-102c-11da-a930-b1c5527a4522
SUMMARY
 :Name
CATEGORIES
 :Birthday
STATUS
 :CONFIRMED
CLASS
 :PRIVATE
X-MOZILLA-ALARM-DEFAULT-UNITS
 :days
X-MOZILLA-ALARM-DEFAULT-LENGTH
 :1
X
 ;MEMBER=AlarmEmailAddress
 :myemailaddress
X-MOZILLA-RECUR-DEFAULT-UNITS
 :years
RRULE
 :FREQ=YEARLY;INTERVAL=1;BYMONTH=2
DTSTART
 ;VALUE=DATE
 :20060226
DTEND
 ;VALUE=DATE
 :20060227
DTSTAMP
 :20050818T211013Z
LAST-MODIFIED
 :20050909T114907Z
BEGIN:VALARM
TRIGGER
 ;VALUE=DURATION
 :-P1D
END:VALARM
END:VEVENT
END:VCALENDAR
Actual Results:  
After selecting the calendar the window just closes.  Nothing happens.  The
events do not show up on the calendar.

Expected Results:  
The events should have showed up on the calendar.

Comment 1

[mperanelli]

Attachment: SampleCalendar.ics

Comment 2

[mperanelli]

Comment on attachment 197907 [details]
SampleCalendar.ics

Just found out how to add an attachment.  Use SampleCalendar.ics to reproduce
the error

Comment 3

[Michiel van Leeuwen (email: mvl+moz@)]

Attachment: patch v1

I'm a bit surprised that manually creating infinitly recurring events work with
the storage calendar. Somehow, importing them from ics doesn't work, because it
doesn't store the null endDate right. This patch fixes it.
(I think it happens to work, because it sets endDate.nativeTime to null,
instead of endDate itself. The storage provider only storaes the nativetime)

Comment 4

[Dan Mosedale (:dmosedale, :dmose)]

Comment on attachment 198349 [details] [diff] [review]
patch v1

r=dmose

Comment 5

[Michiel van Leeuwen (email: mvl+moz@)]

patch checked in