310513 - Updater UI does not display text when updater.ini is malformed

Status: RESOLVED WONTFIX

(Toolkit :: Application Update, defect)

Description

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b5) Gecko/20050928 
Firefox/1.4

If updater.ini is malformed then the text displayed on the UI is missing. This 
is the standard updater.ini file:

[Strings]
Title=Software Update
Info=Firefox is installing your updates and will start in a few moments ...

If you mess with the '[Strings]' line and turn it into '[Stringy]', for 
instance, then *no* strings will show up in the UI. You just get a window with 
a progress bar. Note that Updater works just fine and is successful regardless.

I just think we should have some sort of default values in case updater.ini is 
messed up.

Comment 1

[Ben Turner (not reading bugmail, use the needinfo flag!)]

Darin, what kind of behavior do you want to see here? Should we just fail? Or 
should we try for defaults?

Comment 2

[Darin Fisher]

I don't think we need to worry about the case of updater.ini being malformed. 
In what "real world" cases will updater.ini be messed up?

I'm leaning toward WONTFIX'ing this bug.

Comment 3

[Ben Turner (not reading bugmail, use the needinfo flag!)]

You're right, this probably won't happen very often. Other than some sort of 
botched disk op or someone editing updater.ini by hand I guess we wouldn't see 
this. I was just thinking that a) it's a very visible file (root of the 
firefox folder) and b) it's an .ini file type (one that people are used to 
messing with). But like I said, the update completes regardless, so WONTFIX is 
certainly an option. 

Comment 4

[Darin Fisher]

Yeah, I'd rather close this out and just focus on more visible bugs.