310521 - build with objdir option fails for libprldap.exp: $(srcdir) needed in Makefile.in $(PRLDAP_EXPORT_DEFS) rule

Status: RESOLVED FIXED

(Directory :: LDAP C SDK, defect)

Description

[ymaillvv]

User-Agent:       Mozilla/5.0 (X11; U; Linux i686; en-US; rv:1.0.1) Gecko/20020830
Build Identifier: 

Build from 1.7.8 tarball (i checked the current sources - it should be
reproducible as well) with objdir,  ie. with option like this 

mk_add_options MOZ_OBJDIR=@TOPSRCDIR@/suite-opt

Build failed at <objdir>/directory/c-sdk/ldap/libraries/libprldap/ 
because there wasn't libprldap.exp created. I didn't save the log, yet
the following self-explaining patch corrected the situation:

*** directory/c-sdk/ldap/libraries/libprldap/Makefile.in_orig   Thu Sep 29
15:15:48 2005
--- directory/c-sdk/ldap/libraries/libprldap/Makefile.in        Thu Sep 29
15:14:56 2005
***************
*** 160,166 ****
  
  ifeq ($(USE_DLL_EXPORTS_FILE), 1)
  # recursive gmake rule to create exported symbols file
! $(PRLDAP_EXPORT_DEFS):: libprldap.ex
  ifeq ($(OS_ARCH), WINNT)
        $(GENEXPORTS) Win32 Standard $< $(GENEXPARGS) > $@
  else
--- 160,166 ----
  
  ifeq ($(USE_DLL_EXPORTS_FILE), 1)
  # recursive gmake rule to create exported symbols file
! $(PRLDAP_EXPORT_DEFS):: $(srcdir)/libprldap.ex
  ifeq ($(OS_ARCH), WINNT)
        $(GENEXPORTS) Win32 Standard $< $(GENEXPARGS) > $@
  else



Reproducible: Always

Comment 1

[Rich Megginson]

Has this been committed to a branch yet?  I'm going to fix it on the trunk.

Comment 2

[Mark Smith [:mcs]]

Not fixed on the branch yet either.

Comment 3

[Rich Megginson]

Attachment: files for fix

Comment 4

[Rich Megginson]

Attachment: diffs for fix

Comment 5

[Mark Smith [:mcs]]

Comment on attachment 210484 [details]
diffs for fix

These changes look fine.

Comment 6

[Rich Megginson]

Checkin:
/cvsroot/mozilla/directory/c-sdk/ldap/libraries/libprldap/Makefile.in
version 5.15

Mark, you can close this one as fixed.

Comment 7

[Mark Smith [:mcs]]

Fixed.  Thanks Rich!

Comment 8

[Mark Smith [:mcs]]

Reopened.  Did you commit to the branch?

Comment 9

[Rich Megginson]

No - which branch?

Comment 10

[Mark Smith [:mcs]]

(In reply to comment #9)
> No - which branch?

ldapcsdk_50_client_branch

But a superreview is required to land there.  If we are going to cut a new branch soon (bug 325625) then there is no need to land this on the ldapcsdk_50_client_branch.  Let's see how that goes.

Comment 11

[Rich Megginson]

Can we mark this as resolved since the tbird/seamonkey has taken 5.17 as their branch point?

Comment 12

[Mark Smith [:mcs]]

(In reply to comment #11)
> Can we mark this as resolved since the tbird/seamonkey has taken 5.17 as their
> branch point?

I'd say yes (marking so).