310534 - Dragging text into search box does not overwrite prefilled text

Status: RESOLVED FIXED

(Thunderbird :: Mail Window Front End, defect)

Description

[Adam Guthrie]

In order for the prefilled text in the search bar to go away you have to focus
the search box. This works okay if you're clicking it and typing something in,
but not when you drag text into it.

Steps to reproduce:
1. Open a message.
2. Drag some text in the message into the search bar.

Observe that it dragged it into the prefilled text and did not replace it.

Comment 1

[Jack Eidsness]

This is a pretty goofy looking bug.

Using a recent branch nightly (20051120), dragging text into the search bar (when empty) will insert the selected text right into the middle of the gray text that describes the search type.  

e.g. if you select "foobar" and drag it over to the search bar where it says "Subject or Sender," you could end up with something like "Subjfoobarect or Sender".  It will still be printed in gray.  No search is initiated, Focus is not set to the search bar, and focusing on the search bar (with the mouse or tab) will clear the new gibberish text, making it effectively impossible to do a search from dragged text.

If you drag text into the search bar while a previous search's text is already there, that will work as one might expect.

Comment 2

[Scott MacGregor]

pretty trivial change.

would be a good bug for a contributor new to things to work on. 

Comment 3

[Žiga Sancin]

taking... I've been waiting for the typeahead find changes to land (I hope there aren't any regressions). ;) I'll attach a patch as soon as I'm done with refreshing my source tree.

Comment 4

[Žiga Sancin]

Attachment: patch

Hum, comments?

Comment 5

[Scott MacGregor]

Comment on attachment 213932 [details] [diff] [review]
patch

close...

when i drag text into the search box with this patch, the text gets inserted nicely and we do the search but the clear button never shows up. We must be bypassing the logic which shows the clear button.

Comment 6

[Žiga Sancin]

Attachment: new patch

Ah, the little sexy clear button. ;]

Comment 7

[Scott MacGregor]

Comment on attachment 215121 [details] [diff] [review]
new patch

heh, this patch doesn't work at all for me now :).

When I drag text into the quick search box, it gets inserted along with the existing search criteria title text "Subject or Sender" instead of clearing out the search box and inserting the terms and doing the search :).

Comment 8

[Žiga Sancin]

Nice. Now I'll have to figure out why it works in my tree... lol Would you be so kind and send me your hard disk via UPS? :D Weird.

Comment 9

[Scott MacGregor]

Comment on attachment 215121 [details] [diff] [review]
new patch

weird, I tried this again on a fresh tree and it works fine now. 

I'm going to go ahead and land this patch.

Comment 10

[Scott MacGregor]

thanks for the fix.

Comment 11

[Adam Guthrie]

*** Bug 345890 has been marked as a duplicate of this bug. ***