310559 - control reaches end of non-void function

Status: RESOLVED WONTFIX

(Core Graveyard :: GFX: Gtk, defect)

Description

[Christian Persch (GNOME) (away; not receiving bug mail)]

When corefonts are disabled, I get this compiler warning:

/opt/source/mozilla/trunk-ff/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp: In
function ‘nsresult NS_FontMetricsFamilyExists(nsIDeviceContext*, const nsString&)’:
/opt/source/mozilla/trunk-ff/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp:98:
attention : control reaches end of non-void function
/opt/source/mozilla/trunk-ff/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp: In
function ‘PRUint32 NS_FontMetricsGetHints()’:
/opt/source/mozilla/trunk-ff/mozilla/gfx/src/gtk/nsFontMetricsUtils.cpp:78:
attention : control reaches end of non-void function

Comment 1

[Christian Persch (GNOME) (away; not receiving bug mail)]

Attachment: fix

Comment 2

[Boris Zbarsky [:bzbarsky]]

Did this ever get checked in?  If not, should I do that?  Note that on trunk this code is going away....

Comment 3

[Mats Palmgren (inactive)]

gfx/src/gtk/ has been removed on trunk.
This bug doesn't look like a branch candidate to me.

-> WONTFIX