310567 - can no longer forward multiple emails (i.e. >1); IMAP only, POP is ok

Status: RESOLVED FIXED

(Thunderbird :: Message Compose Window, defect)

Description

[Calum Mackay]

Highlighting multiple emails (>1) and then ctrl-L to forward them no longer
works. A compose window appears, but it does not have the messages
auto-attached. Doing this with just a single message highlighted works as expected. 

[I am forwarding msgs as attachments]

I build nightly from CVS, and this problem is not present in my 20050916 build,
but is present in my 0917 build, and then in every build onwards including
today. My checkouts are done at 0400Z.

Comment 1

[Calum Mackay]

sigh; typo in summary

Comment 2

[David :Bienvenu]

IMAP or POP3 messages? This works for me, except that the names of the
attachments are wrong (bug 309208). They're all the same as the first forwarded
message, though the contents are correct. Any messages on the js console?

Comment 3

[Calum Mackay]

This is when using an IMAP server. Very odd, I see bug 309208 but that is
definitely not what I am seeing.

When I select multiple messages, and then ctrl-L, my new compose window has no
attachments. There is not even the attachment panel. Sending the msg anyway
results in an empty email on receipt. Well, not empty, necessarily, of course,
but certainly no attachments.

Nothing in JS console whatsoever when I do this.

Comment 4

[Calum Mackay]

I should add that this is 100% reproducible on many builds of mine after 0917.
Not reproducible at all using my 0916 build (on the same system).

Comment 5

[Calum Mackay]

Another interesting data point: using the same build (today's) I can reproduce
the problem with 3 different IMAP servers, but I cannot reproduce the problem
with a POP server (Google Mail). With the POP server I instead see bug 309208
(as expected).

Comment 6

[Calum Mackay]

Sigh. In comment 3, when I said "I see bug 309208" I meant: I am aware of it. I
did not actually experience it :)

o Over IMAP I experience *this* bug. Bug 309208 obviously doesn't then apply
(since I don't get an attachment panel at all).

o Over POP I don't experience this bug, but I do experience bug 309208

Comment 7

[David :Bienvenu]

Attachment: proposed fix

this should fix both bugs - multiple imap and local messages forward fine for
me now, as do .eml files.

Comment 8

[Scott MacGregor]

Comment on attachment 198000 [details] [diff] [review]
proposed fix

I think this is the wrong patch?

Comment 9

[David :Bienvenu]

Attachment: proposed fix

sigh, wrong tree again. This patch makes it so we only set mOrigMsgHdr if we're
doing something with a .eml file that we've opened, and otherwise, we go back
to getting the msg hdr from the uri(s).