310637 - dom_loadsave.xpt is missing after installation of SeaMonkey

Status: RESOLVED FIXED

(SeaMonkey :: Installer, defect)

Description

[mv_van_rantwijk]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20050920 MultiZilla/1.8.1.0p SeaMonkey/1.1a
Build Identifier:  

I tried to add a progress listener like this:

var xmlRequest = new XMLHttpRequest();
xmlRequest.onprogress = onXMLProgress;
onXMLProgress: function(aEvent)
{
    var percentage = (aEvent.position * 100) / aEvent.totalSize;
    statusMeter.value = percentage;
}

but the .position and .totalSize properties keep returning undefined, even after
aEvent.QueryInterface(Components.interfaces.nsIDOMLSProgressEvent).position 

Biesi helped me to explain what the problem was, so I copied the file and
removed xpti.dat and restarted SeaMonkey to see that all problems were gone :-)

Reproducible: Always

Comment 1

[Christian :Biesinger (don't email me, ping me on IRC)]

(this was with an installer build)

Comment 2

[Andrew Schultz]

the info from dom_loadsave.xpt should be included in browser.xpt (or whatever
GRE-ish thing the windows packages it into).

mozilla/xpinstall/packager/xptlink.pl's stated purpose:
# traverse directories created by pkgcp.pl and merge multiple .xpt files into
# a single .xpt file to improve startup performance

dom_loadsave.xpt is included in packages-unix and its interfaces seem to be
listed in browser.xpt on linux.  dom_loadsave.xpt is included in basebrowser-win.

Can you provide a testcase so I can verify this works on linux?

Comment 3

[Alex Vincent [:WeirdAl]]

Per comment 2,
http://lxr.mozilla.org/seamonkey/source/xpinstall/packager/packages-win

Comment 4

[Andrew Schultz]

what exactly are we looking at in packages-win?

dom_loadsave.xpt is listed here:
http://lxr.mozilla.org/seamonkey/source/embedding/config/basebrowser-win#182

Comment 5

[Serge Gautherie (:sgautherie)]

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9a1) Gecko/20051212 SeaMonkey/1.5a] (nightly) (W2Ksp4)

Confirming:
.Zip: Has <dom_canvas.xpt>.
.Exe: Misses <dom_canvas.xpt>.

Comment 6

[Serge Gautherie (:sgautherie)]

Based on
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/suite/installer/windows/packages&rev=1.55&mark=116#115>
this was fixed by bug 351917 attachment 260915 [details] [diff] [review].
(Maybe it had already been solved in the non-NSIS installer ? Anyway.)

[Mozilla/5.0 (Windows; U; Windows NT 5.0; en-US; rv:1.9pre) Gecko/2008042302 SeaMonkey/2.0a1pre] (nightly) (W2Ksp4)

.Zip and .Exe:
Have "global" <browser.xpt>, which contains the |*DOMLS*| data.

R.Fixed

Comment 7

[Serge Gautherie (:sgautherie)]

(In reply to comment #6)
> (Maybe it had already been solved in the non-NSIS installer ? Anyway.)

Indeed:

.Zip had been fixed by bug 302444
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/xpinstall/packager/packages-static-win&rev=1.80.4.6&mark=112#108>

.Exe was fixed by bug 320370
<http://bonsai.mozilla.org/cvsblame.cgi?file=/mozilla/embedding/config/basebrowser-installer-win.pkg&rev=1.29.4.6&mark=172#168>