[adblocking] Occasional Flash ad hangs Camino (block iframes from mspaceads.com)

VERIFIED FIXED

Status

Camino Graveyard
General
VERIFIED FIXED
12 years ago
10 years ago

People

(Reporter: Samuel Sidler (old account; do not CC), Assigned: Simon Fraser)

Tracking

({fixed1.8})

Details

(URL)

I'm getting an occasional Flash ad that's hanging Camino and forcing me to Force
Quit it.

I've tracked down what I think is the problem, which happens to be JS. The
following code calls in the ad:

 <table width="800" border="0" align="center" cellspacing="0" cellpadding="0">
  <tr>
   <td height="96" align="center" valign="top" bgcolor="003399">
    <script language="Javascript">
     <!-- 
      oas_ad("www.myspace.com/user/viewprofile,11013005","Frame1");
     //-->
    </script>				
   </td>
  </tr>
 </table>

In the source, there are only a few JS files which are located at the following
locations:

 http://x.myspace.com/js/myspace.js
 http://x.myspace.com/js/ASJS014.js
 http://x.myspace.com/js/functions.js

The second JS file has what I think calls the ad.

So... can we put in a rule for JS that uses the name "oas_ad"? I'm not sure how
else to block it, but that should work.
(Assignee)

Comment 1

12 years ago
We can't block JS files with ad blocking CSS (alas).
(Assignee)

Comment 2

12 years ago
We need to know what flash ad that was; I have this bookmarklet in my toolbar to
dump Flash (in the main frame):

javascript:
plugins = document.getElementsByTagName('embed');
var pluginSources = '<dl>';
for (var i = 0; i < plugins.length; i ++)
{
    var thisPlugin = '<dt>' + plugins[i].type + '</dt><dd>src = ' +
plugins[i].src + '</dd>';
    pluginSources += thisPlugin;
}

pluginSources += '</dl>';
document.writeln('<html><body>' + pluginSources + '</body></html>');
document.close();
(Reporter)

Comment 3

12 years ago
That bookmarklet give me a blank wyciwyg page with the following source: 

 <html><body><dl></dl></body></html>

If you refresh enough on the following link, you're bound to get an occasional
Flash ad. I get them ~1/8 times with a shift-reload. Only a few of the ads hang
Camino, but those seem to repeat quite a bit.
I've been shift-reloading that page for 10 minutes and haven't seen a single ad,
let alone a flash one.  (There is a blank iframe there where an ad would go,
src=http://deLB.mspaceads.com/html.ng/site=myspace&po
sition=leaderboard&page=11013005&rand=468490599&friendid=294566860)

In that vein, if it's really the 2nd JS that controls that ad, it puts up an
iframe beginning with a src=http://de**.mspaceads.com/ (where ** are some
two-capital-letter combos)

We're already blocking mspaceads.com for imgs; if we do the same for iframes,
that should probably should solve the problem.
(Reporter)

Comment 5

12 years ago
That's funny. On the first load I got an ad. In any case, looking at the JS, I
think Smokey's right.

Updating summary to reflect what we assume is needed to fix this, which is
blocking iframes from mspace.com.
Summary: [adblocking] Occasional Flash ad hangs Camino → [adblocking] Occasional Flash ad hangs Camino (block iframes from mspaceads.com)
(Reporter)

Comment 6

12 years ago
Proposed patch from bug 306796 fixes this.
Depends on: 306796
(Assignee)

Comment 7

12 years ago
Fixed.
Status: NEW → RESOLVED
Last Resolved: 12 years ago
Resolution: --- → FIXED

Updated

12 years ago
Keywords: fixed1.8
(Reporter)

Updated

10 years ago
Status: RESOLVED → VERIFIED
You need to log in before you can comment on or make changes to this bug.