310732 - [BEOS] Porting XULRunner to BeOS

Status: RESOLVED FIXED

(Toolkit Graveyard :: XULRunner, defect)

Description

[tqh]

I'm trying to get XULRunner to build under BeOS and run into trouble I need some
help with.

Currently (after patching toolkit/library/Makefile.in) I'm stuck on this error:

Building tools from tier 2/9/50
make[3]: Entering directory `/mozdev/xrun/js'
make[4]: Entering directory `/mozdev/xrun/js/src/fdlibm'
/bin/sh: -c: line 1: syntax error near unexpected token `;'
/bin/sh: -c: line 1: `for d in ; do   /boot/home/config/bin/make -C $d libs;  done'

I guess this is the problem line:
http://lxr.mozilla.org/seamonkey/source/Makefile.in#503

What do I need to do to fix this?

Comment 1

[tqh]

Attachment: adding -ltracker to toolkit/library/Makefile.in

Comment 2

[Benjamin Smedberg]

I frankly have no clue why you would have the makefile errors: $(tier_x_dirs)
should always have content.

Comment 3

[tqh]

Yes, shouldn't it be there by the Makefile in /mozdev/mozilla?

I'm very confused as well.

Comment 4

[tqh]

Oh, /mozdev shouldn't be there. That's my disk.

Comment 5

[tqh]

Ok, echoed those in Makefile, I guess the problem isn't really at that place:
tier 2: js xpcom modules/libreg xpcom/obsolete

tier 9: js/src/xpconnect intl modules/libutil netwerk modules/libjar uriloader
modules/libpref modules/libimg caps rdf parser/expat parser/htmlparser gfx
modules/libpr0n sun-java modules/plugin dom view widget content layout docshell
webshell embedding editor xpfe/appshell accessible

tier 50: chrome profile db xpfe toolkit/components toolkit xpinstall js/jsd
security/manager toolkit/library xpcom/stub

Comment 6

[tqh]

I've confirmed that it'ss this line that fails:

http://lxr.mozilla.org/seamonkey/source/config/rules.mk#622

Comment 7

[tqh]

Attachment: Check if tools-dir is used [checked in 1.8branch and trunk]

Dunno if this is the right solution but it build with this. it checks if there
is any tools-dir before going into loop.

I tried with --enable-tests and such but this is the only way it completes the
build so far.

Is this the right way to go about this?

Comment 8

[Benjamin Smedberg]

Comment on attachment 198245 [details] [diff] [review]
Check if tools-dir is used [checked in 1.8branch and trunk]

Good catch.

Comment 9

[Asa Dotzler [:asa]]

Ben, is there any risk at all to our primary platforms by taking this patch?

Comment 10

[Benjamin Smedberg]

no, as a build-system patch any risk would show up immediately on tinderbox

Comment 11

[Asa Dotzler [:asa]]

Comment on attachment 198245 [details] [diff] [review]
Check if tools-dir is used [checked in 1.8branch and trunk]

ben, you're on the hook for watching tinderbox then :-)

Comment 12

[Benjamin Smedberg]

Comment on attachment 198245 [details] [diff] [review]
Check if tools-dir is used [checked in 1.8branch and trunk]

tooldirs patch checked in, trunk and 1.8branch - leaving bug open for whatever
other patches are necessary for BeOS XULRunner

Comment 13

[tqh]

Comment on attachment 198167 [details] [diff] [review]
adding -ltracker to toolkit/library/Makefile.in

Could you review this one as well?

We need tracker for the native fileopen-dialog used in BeOS.


There are no other changes needed for building. (Running things might be a
different story).

Comment 14

[Benjamin Smedberg]

Comment on attachment 198167 [details] [diff] [review]
adding -ltracker to toolkit/library/Makefile.in

I don't know anything about BeOS, but I'll give moa+

Do you care about the 1.8 branch, or do you just want this on trunk?

Comment 15

[tqh]

I want it on the trunk for now.

Comment 16

[Benjamin Smedberg]

OK, fixed on trunk (and marking fixed1.8 to keep this off 1.8 radars for the
tool-dirs fix).