310750 - Advanced search page fails w3 validation

Status: RESOLVED FIXED

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

Below are the results of attempting to parse this document with an SGML parser.

   1. Error Line 98 column 92: end tag for element "A" which is not open.

...format=advanced'>Give me some help</a> (reloads page.)</p>");

      The Validator found an end tag for the above element, but that element is
not currently open. This is often caused by a leftover end tag from an element
that was removed during editing, or by an implicitly closed element (if you have
an error related to an element being used where it is not allowed, this is
almost certainly the case). In the latter case this error will disappear as soon
as you fix the original problem.

      If this error occured in a script section of your document, you should
probably read this FAQ entry.

      ✉
   2. Error Line 98 column 112: end tag for element "P" which is not open.

...e me some help</a> (reloads page.)</p>");

      The Validator found an end tag for the above element, but that element is
not currently open. This is often caused by a leftover end tag from an element
that was removed during editing, or by an implicitly closed element (if you have
an error related to an element being used where it is not allowed, this is
almost certainly the case). In the latter case this error will disappear as soon
as you fix the original problem.

      If this error occured in a script section of your document, you should
probably read this FAQ entry.

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

divide between < and /

Comment 2

[Frédéric Buclin]

Comment on attachment 233211 [details] [diff] [review]
patch for tip

>-      document.write("<p><a href='query.cgi?help=1&amp;format=advanced'>Give me some help</a> (reloads page.)</p>");
>+      document.write('<p><a href="query.cgi?help=1&amp;format=advanced">Give me some help<' + "/a> (reloads page.)<" + "/p>");


No! They must be correctly escaped: in document.write(), </foo> must be written <\/foo>

Comment 3

[victory <[e-mail]>]

Attachment: patch for tip v2

Comment 4

[Frédéric Buclin]

Comment on attachment 233369 [details] [diff] [review]
patch for tip v2

r=LpSolit

Comment 5

[Frédéric Buclin]

Checking in template/en/default/search/search-advanced.html.tmpl;
/cvsroot/mozilla/webtools/bugzilla/template/en/default/search/search-advanced.html.tmpl,v  <--  search-advanced.html.tmpl
new revision: 1.26; previous revision: 1.25
done