310752 - Tabular reports result page fails w3 validation

Status: RESOLVED DUPLICATE of bug 252856

(Bugzilla :: User Interface, defect)

Description

[Joel Peshkin]

A whole pile of errors....

reports/report.html.tmpl:(/home/bugzilla/tip/report.cgi)
Checking with HTML 4.01 Transitional document type...
*** Errors: ***
Error at line 131, character 46:  unknown entity "bug_file_loc_type"
Error at line 131, character 79:  unknown entity "bug_status"
Error at line 131, character 114:  unknown entity "bugidtype"
Error at line 131, character 132:  unknown entity "chfieldto"
Error at line 131, character 146:  unknown entity "emailassigned_to1"
Error at line 131, character 166:  unknown entity "emailassigned_to2"
Error at line 131, character 186:  unknown entity "emailcc2"
Error at line 131, character 197:  unknown entity "emailqa_contact2"
Error at line 131, character 216:  unknown entity "emailreporter2"
Error at line 131, character 233:  unknown entity "emailtype1"
Error at line 131, character 254:  unknown entity "emailtype2"

Comment 1

[victory <[e-mail]>]

Attachment: patch for tip

Comment 2

[Frédéric Buclin]

Comment on attachment 233208 [details] [diff] [review]
patch for tip

>-            <a href="[% urlbase %]&amp;
>+            <a href="[% urlbase FILTER html %]&amp;

Do not filter urlbase. It should be safe. And 008filter.t would now complain that filterexceptions.pl has extra members.


>Index: template/en/default/reports/report.html.tmpl

>         [% formaturl = "report.cgi?$switchbase&width=$width&height=$height" _ 
>-                       "&action=wrap" %]
>+                       "&action=wrap" FILTER html %]

A much better approach is to filter switchbase at the beginning of the template, and then use it as it is now. Moreover, replace '&' by &amp; instead of filtering all this stuff. I fear some data will be overfiltered.


>-          [% switchbase %]&amp;action=wrap&amp;format=
>+          [% switchbase FILTER html %]&amp;action=wrap&amp;format=

See my remark above.

Comment 3

[victory <[e-mail]>]

Attachment: patch for tip v2

Comment 4

[Frédéric Buclin]

Comment on attachment 233224 [details] [diff] [review]
patch for tip v2

Patch already applied as part of bug 252856.

Comment 5

[Frédéric Buclin]

*** This bug has been marked as a duplicate of 252856 ***