310800 - No scroll in download manager

Status: RESOLVED WORKSFORME

(Toolkit :: Downloads API, defect)

Description

[Jesse Peden]

User-Agent:       Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4
Build Identifier: Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.8b4) Gecko/20050908 Firefox/1.4

There is no scroll bar in the Download Manager so you will eventually run into
the problem of not being able to see the Clean Up button at the bottom because
the window stretches to fit all of the downloaded files into the list instead of
just having a scroll bar and just having the main window statically sized.  I
had downloaded roughly 30 files and had to click "Remove" on each of them until
I could finally see the Clean Up button at the bottom.

Reproducible: Always

Steps to Reproduce:
1.Tell the download manager that you will clean it up manually
2.Download a bunch of files (20+ ?)
3.Open the download manager and you won't be able to see the Clean Up button at
the bottom until you remove some of the files from the list.



Expected Results:  
The programmers should have used either a scroll bar in the window or put the
Clean Up button at the top of the window so that no matter how many files are in
the list you will be able to press that button if you need to.

Comment 1

[Dave Townsend [:mossop]]

Are you using the default theme? If not please test with the default theme.

Comment 2

[Kevin Brosnan]

Dupe of Bug 259848 which is a dupe of Bug 307654

*** This bug has been marked as a duplicate of 307654 ***

Comment 3

[Robert Strong (they/them - no direct email)]

(In reply to comment #2)
> Dupe of Bug 259848 which is a dupe of Bug 307654
> 
> *** This bug has been marked as a duplicate of 307654 ***
This is most likely a theme issue but what ever the case it isn't fixed by the
checkin for bug 307654.

Comment 4

[Jesse Peden]

Stop saying that it's a duplicate.  Those other messages are about the Extension
Manager.  I'm talking about the Download Manager.

Comment 5

[Dave Townsend [:mossop]]

One person said it was a duplicate, the other disagreed. Can you please say if
you are using a non-default theme and if so do you still see the same problem
with firefox's default theme?

Comment 6

[Robert Strong (they/them - no direct email)]

Can you attach a screenshot of the problem and answer the question in comment #1?

Comment 7

[Jesse Peden]

One one profile on the computer I am using a theme that was downloaded from 
the Mozilla website, but on another profile I am using the default firefox 
theme.  Both have the same problem.

As for the screen shot... no.  I don't want to download another 30 something 
files just to take a screen shot.  It's SIMILAR the the Extension Manager bug 
that was posted a while back.  Maybe they'll have a screen shot.

Comment 8

[Robert Strong (they/them - no direct email)]

I'm unable to reproduce using the default theme. The Download Manage Tweak
extension adds buttons to the bottom of the Download Manager which could
possibly cause this to happen in a similar manner as what was occurring with the
Extension Manager. I fixed that Extension Manager bug a short time ago and a
screenshot for that is of no use for what you have reported.

Comment 9

[Robert Strong (they/them - no direct email)]

Attachment: screenshot

I suspect this screenshot shows what is happening with the download manager. It
requires that you have a directory specified to always save your downloads and
the associated pref set accordingly. If this is it this is essentially the same
as bug 307654 which was for the Extension Manager though not nearly as bad due
to having less items occupying the bottom row in the window. I suspect the same
approach can be taken to fix this as well.

Comment 10

[Ria Klaassen (not reading all bugmail)]

Mozilla/5.0 (Windows; U; Windows NT 5.1; en-US; rv:1.9a1) Gecko/20051002
Firefox/1.6a1 ID:2005100222

Using the default theme, the download manager shows a scrollbar:
http://img301.imageshack.us/img301/7067/downloadmanager1bm.png

Comment 11

[Robert Strong (they/them - no direct email)]

Agreed and I should have pointed out that I had to resize the window from the
default to get the affect as shown in the screenshot which is the default theme.
As shown in Bug 307654 it is trivial to make it so the scrollbar continues to be
shown even when the window is smaller than the contents.

Comment 12

[Jesse Peden]

Attachment: Download Manager window screen-shot

Comment 13

[Jesse Peden]

Comment on attachment 198400 [details]
Download Manager window screen-shot

It seemed like the Download Manager window was automatically resizing to fit
all of the entries in the list visible and as such the scroll bar was not
there.	As for the default/non-default theme idea... That shouldn't fix
anything since the scroll-bar is an API call done by the program... not the
theme.	The theme is just a coloring and design extension.  Here is an
attatched screen-shot of the Download  Manager just in case.  This is the whole
Download Manager window.  The theme I'm using, by the way, is Aquatint 1.4.3

Comment 14

[Kevin Brosnan]

Does the scrollbar appear if you switch back to the default theme? This is an
important step.

Comment 15

[Jesse Peden]

Yes.  If I switch to the default (classic) theme it all works fine.  This is
confusing though because like I said in my previous reply, the scrollbar should
be an API call and not dependant on which theme you're using.  The theme should
only define what colors to use and which icons, etc...  Not the actual program
interface.

Comment 16

[Robert Strong (they/them - no direct email)]

Well, they do rely on the theme - resolving WFM.