310831 - LANGPACK_TITLE key in installer.inc should contain the langpack identifier so as to allow reordering

Status: VERIFIED WONTFIX

(Firefox :: Installer, defect)

Description

[Andrés G. Aragoneses]

When installing Firefox, you can see the text "Installing: ab-CD Language Pack".

The localizable string for the last part of that sentence is only "Language Pack":

/mozilla/browser/locales/en-US/installer/installer.inc:
#define LANGPACK_TITLE Language Pack

However, in some languages the correct way should be to put "ab-CD" as the last
term. For example, in Spanish, it should be "Paquete de idioma es-ES", instead
of the actual "es-ES Paquete de idioma".

The localizable string should be changed to accept the reordering of the term,
as other strings allow this (for example: "#define BROWSER_SHORT
$ProductShortName$ Browser" in Spanish is "#define BROWSER_SHORT Navegador
$ProductShortName$").

Comment 1

[Robert Strong (they/them - no direct email)]

This doesn't affect the NSIS installer which has been in use since Firefox 2.0.

Resolving -> WONTFIX as it applies to fixing this bug for Firefox 1.5 since that is what this bug is about.

Comment 2

[Andrés G. Aragoneses]

Ok, can anyone confirm this is not a problem anymore in 2.0 or higher? Tony? Ricardo? If you confirm, mark as VERIFIED please.

Comment 3

[Robert Strong (they/them - no direct email)]

installer.inc is no longer used... the strings are here
http://mxr.mozilla.org/mozilla-central/source/browser/locales/en-US/installer/custom.properties#95

Comment 4

[Andrés G. Aragoneses]

So I guess the replacement for that string is:

STATUS_INSTALL_LANG=Installing Language Files (${AB_CD})…

Right? Does this have l10n support? If yes, does this structure allow the placement of $AB_CD in other place of the translated sentence? Sorry, I'm not familiar with l10n lately, haven't contributed for long time. Ricardo may offer much help here than me.

Thanks.

Comment 5

[Robert Strong (they/them - no direct email)]

http://mxr.mozilla.org/l10n-central/source/es-ES/browser/installer/custom.properties#77

Comment 6

[Andrés G. Aragoneses]

Marking VERIFIED. Thanks.